Make toDelegate safe for function pointers
#10599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @0xEAB! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#10599" |
0xEAB
force-pushed
the
bolpat/patch-1/but-it-actually-works
branch
2 times, most recently
from
c569c33 to
89d37f4
Compare
LightBender
approved these changes
Dec 29, 2024
rikkimax
requested changes
Dec 29, 2024
0xEAB
force-pushed
the
bolpat/patch-1/but-it-actually-works
branch
from
89d37f4 to
65c7071
Compare
0xEAB
force-pushed
the
bolpat/patch-1/but-it-actually-works
branch
from
65c7071 to
5ebfe85
Compare
rikkimax
approved these changes
Dec 30, 2024
Co-authored-by: Elias Batek <0xEAB@users.noreply.github.com>
0xEAB
force-pushed
the
bolpat/patch-1/but-it-actually-works
branch
from
5ebfe85 to
ac35640
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revamp of #8769.
While I’m not sure whether it covers all use-cases that @Bolpat’s patch had considered and that exist (also see Dennis’ unanswered question over there), it at least passes the testsuite on my machine.
As this is a
@trustedhack, I’d appreciate my patch to be thoroughly reviewed.