Skip to content

Remove 'needs rebase' and 'needs work' on new push #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2017

Conversation

wilzbach
Copy link
Member

On "needs work" and "needs rebase" are commonly used to mark an PR as "inactive" (aka depending on user interaction):

https://github.com/dlang/phobos/pulls?q=is%3Aopen+is%3Apr+label%3A%22needs+rebase%22
https://github.com/dlang/phobos/pulls?q=is%3Aopen+is%3Apr+label%3A%22needs+work%22

Thus as a simple first step, this will remove these labels as well when they are existent.

Small gotchas

  • AFAIK DMD and Druntime use different labels atm (e.g. DMD has only "Needs Work")
  • I think a new push usually displays a contributor interaction and it can be assumed that the required work was done and the PR can go back into the review queue.

@andralex andralex merged commit a121412 into dlang:master Feb 22, 2017
@andralex
Copy link
Member

cool cool cool

@andralex
Copy link
Member

There would be the "remove @andralex" thing after I post a comment (or outright merge the PR), but that's okay :).

@wilzbach wilzbach deleted the remove-needs-rebase branch February 22, 2017 21:59
@wilzbach
Copy link
Member Author

There would be the "remove @andralex" thing after I post a comment (or outright merge the PR), but that's okay :).

On the stage for a PR idea that @WebDrake proposed, this would be done in some sense.
At least the rough idea is that the "needs decision" stage is then very similar to "@andralex".
Btw if we can also switch to requesting reviews from you directly (instead of the @andralex label) - they would also get automatically get cleared.
(IIRC "@andralex" predates the review feature on GH).

(or outright merge the PR)

This this really matter? Don't you filter for "open" anyways?
Just asking, because it would be trivial to automatically unlabel a PR after merge.

@andralex
Copy link
Member

@wilzbach I do filter for open, so no need to do much after merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants