Skip to content

Commit 8673029

Browse files
CyberShadowGeod24
CyberShadow
authored and
Geod24
committed
Don't even query Bugzilla for non-Bugzilla projects
Follow-up to #272. Apply the is-a-Bugzilla-using-project check to the code which parses Bugzilla references and queries details for each from Bugzilla, too. The test suite fallout is larger this time because we need to patch the repo slug in the other-org tests, which means we can't reuse the existing payloads (at least not without introducing a "read this other payload, do a search&replace, and serve it instead" mechanism).
1 parent 2137214 commit 8673029

9 files changed

+1292
-14
lines changed

‎data/hooks/github/notdlang_bar_merged_12347.json

Lines changed: 449 additions & 0 deletions
Large diffs are not rendered by default.

‎data/hooks/github/notdlang_foo_open_12346.json

Lines changed: 432 additions & 0 deletions
Large diffs are not rendered by default.

‎data/payloads/github_repos_notdlang_bar_issues_12347_comments

Lines changed: 254 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,254 @@
1+
[
2+
{
3+
"url": "https://api.github.com/repos/notdlang/bar/issues/comments/267737793",
4+
"html_url": "https://github.com/notdlang/bar/pull/12347#issuecomment-267737793",
5+
"issue_url": "https://api.github.com/repos/notdlang/bar/issues/12347",
6+
"id": 267737793,
7+
"user": {
8+
"login": "timotheecour",
9+
"id": 2194784,
10+
"avatar_url": "https://avatars.githubusercontent.com/u/2194784?v=3",
11+
"gravatar_id": "",
12+
"url": "https://api.github.com/users/timotheecour",
13+
"html_url": "https://github.com/timotheecour",
14+
"followers_url": "https://api.github.com/users/timotheecour/followers",
15+
"following_url": "https://api.github.com/users/timotheecour/following{/other_user}",
16+
"gists_url": "https://api.github.com/users/timotheecour/gists{/gist_id}",
17+
"starred_url": "https://api.github.com/users/timotheecour/starred{/owner}{/repo}",
18+
"subscriptions_url": "https://api.github.com/users/timotheecour/subscriptions",
19+
"organizations_url": "https://api.github.com/users/timotheecour/orgs",
20+
"repos_url": "https://api.github.com/users/timotheecour/repos",
21+
"events_url": "https://api.github.com/users/timotheecour/events{/privacy}",
22+
"received_events_url": "https://api.github.com/users/timotheecour/received_events",
23+
"type": "User",
24+
"site_admin": false
25+
},
26+
"created_at": "2016-12-17T02:37:29Z",
27+
"updated_at": "2016-12-17T02:37:29Z",
28+
"body": "couldn't that be done with tooling ? (if not with existing traits, at least via instrumenting foo)"
29+
},
30+
{
31+
"url": "https://api.github.com/repos/notdlang/bar/issues/comments/267759950",
32+
"html_url": "https://github.com/notdlang/bar/pull/12347#issuecomment-267759950",
33+
"issue_url": "https://api.github.com/repos/notdlang/bar/issues/12347",
34+
"id": 267759950,
35+
"user": {
36+
"login": "WalterBright",
37+
"id": 568298,
38+
"avatar_url": "https://avatars.githubusercontent.com/u/568298?v=3",
39+
"gravatar_id": "",
40+
"url": "https://api.github.com/users/WalterBright",
41+
"html_url": "https://github.com/WalterBright",
42+
"followers_url": "https://api.github.com/users/WalterBright/followers",
43+
"following_url": "https://api.github.com/users/WalterBright/following{/other_user}",
44+
"gists_url": "https://api.github.com/users/WalterBright/gists{/gist_id}",
45+
"starred_url": "https://api.github.com/users/WalterBright/starred{/owner}{/repo}",
46+
"subscriptions_url": "https://api.github.com/users/WalterBright/subscriptions",
47+
"organizations_url": "https://api.github.com/users/WalterBright/orgs",
48+
"repos_url": "https://api.github.com/users/WalterBright/repos",
49+
"events_url": "https://api.github.com/users/WalterBright/events{/privacy}",
50+
"received_events_url": "https://api.github.com/users/WalterBright/received_events",
51+
"type": "User",
52+
"site_admin": false
53+
},
54+
"created_at": "2016-12-17T12:22:46Z",
55+
"updated_at": "2016-12-17T12:22:46Z",
56+
"body": "Why not pull it?"
57+
},
58+
{
59+
"url": "https://api.github.com/repos/notdlang/bar/issues/comments/267772880",
60+
"html_url": "https://github.com/notdlang/bar/pull/12347#issuecomment-267772880",
61+
"issue_url": "https://api.github.com/repos/notdlang/bar/issues/12347",
62+
"id": 267772880,
63+
"user": {
64+
"login": "andralex",
65+
"id": 566679,
66+
"avatar_url": "https://avatars.githubusercontent.com/u/566679?v=3",
67+
"gravatar_id": "",
68+
"url": "https://api.github.com/users/andralex",
69+
"html_url": "https://github.com/andralex",
70+
"followers_url": "https://api.github.com/users/andralex/followers",
71+
"following_url": "https://api.github.com/users/andralex/following{/other_user}",
72+
"gists_url": "https://api.github.com/users/andralex/gists{/gist_id}",
73+
"starred_url": "https://api.github.com/users/andralex/starred{/owner}{/repo}",
74+
"subscriptions_url": "https://api.github.com/users/andralex/subscriptions",
75+
"organizations_url": "https://api.github.com/users/andralex/orgs",
76+
"repos_url": "https://api.github.com/users/andralex/repos",
77+
"events_url": "https://api.github.com/users/andralex/events{/privacy}",
78+
"received_events_url": "https://api.github.com/users/andralex/received_events",
79+
"type": "User",
80+
"site_admin": false
81+
},
82+
"created_at": "2016-12-17T16:49:06Z",
83+
"updated_at": "2016-12-17T16:49:06Z",
84+
"body": "@timotheecour it could, but @WalterBright warned the tool would be highly nontrivial.\r\n\r\n@WalterBright good idea, I'll pull."
85+
},
86+
{
87+
"url": "https://api.github.com/repos/notdlang/bar/issues/comments/267773560",
88+
"html_url": "https://github.com/notdlang/bar/pull/12347#issuecomment-267773560",
89+
"issue_url": "https://api.github.com/repos/notdlang/bar/issues/12347",
90+
"id": 267773560,
91+
"user": {
92+
"login": "andralex",
93+
"id": 566679,
94+
"avatar_url": "https://avatars.githubusercontent.com/u/566679?v=3",
95+
"gravatar_id": "",
96+
"url": "https://api.github.com/users/andralex",
97+
"html_url": "https://github.com/andralex",
98+
"followers_url": "https://api.github.com/users/andralex/followers",
99+
"following_url": "https://api.github.com/users/andralex/following{/other_user}",
100+
"gists_url": "https://api.github.com/users/andralex/gists{/gist_id}",
101+
"starred_url": "https://api.github.com/users/andralex/starred{/owner}{/repo}",
102+
"subscriptions_url": "https://api.github.com/users/andralex/subscriptions",
103+
"organizations_url": "https://api.github.com/users/andralex/orgs",
104+
"repos_url": "https://api.github.com/users/andralex/repos",
105+
"events_url": "https://api.github.com/users/andralex/events{/privacy}",
106+
"received_events_url": "https://api.github.com/users/andralex/received_events",
107+
"type": "User",
108+
"site_admin": false
109+
},
110+
"created_at": "2016-12-17T16:58:13Z",
111+
"updated_at": "2016-12-17T16:58:13Z",
112+
"body": "Auto-merge toggled on"
113+
},
114+
{
115+
"url": "https://api.github.com/repos/notdlang/bar/issues/comments/267775518",
116+
"html_url": "https://github.com/notdlang/bar/pull/12347#issuecomment-267775518",
117+
"issue_url": "https://api.github.com/repos/notdlang/bar/issues/12347",
118+
"id": 267775518,
119+
"user": {
120+
"login": "CyberShadow",
121+
"id": 160894,
122+
"avatar_url": "https://avatars.githubusercontent.com/u/160894?v=3",
123+
"gravatar_id": "",
124+
"url": "https://api.github.com/users/CyberShadow",
125+
"html_url": "https://github.com/CyberShadow",
126+
"followers_url": "https://api.github.com/users/CyberShadow/followers",
127+
"following_url": "https://api.github.com/users/CyberShadow/following{/other_user}",
128+
"gists_url": "https://api.github.com/users/CyberShadow/gists{/gist_id}",
129+
"starred_url": "https://api.github.com/users/CyberShadow/starred{/owner}{/repo}",
130+
"subscriptions_url": "https://api.github.com/users/CyberShadow/subscriptions",
131+
"organizations_url": "https://api.github.com/users/CyberShadow/orgs",
132+
"repos_url": "https://api.github.com/users/CyberShadow/repos",
133+
"events_url": "https://api.github.com/users/CyberShadow/events{/privacy}",
134+
"received_events_url": "https://api.github.com/users/CyberShadow/received_events",
135+
"type": "User",
136+
"site_admin": false
137+
},
138+
"created_at": "2016-12-17T17:34:32Z",
139+
"updated_at": "2016-12-17T17:34:32Z",
140+
"body": "> @timotheecour it could, but @WalterBright warned the tool would be highly nontrivial.\r\n\r\nJust brute-force it.\r\n\r\nExpand all imports to selective imports of all symbols, then wrap imports in a DustMite comment block and run it through DustMite. We did something similar at DConf 2016 to minimize imports in dfoo."
141+
},
142+
{
143+
"url": "https://api.github.com/repos/notdlang/bar/issues/comments/267775601",
144+
"html_url": "https://github.com/notdlang/bar/pull/12347#issuecomment-267775601",
145+
"issue_url": "https://api.github.com/repos/notdlang/bar/issues/12347",
146+
"id": 267775601,
147+
"user": {
148+
"login": "CyberShadow",
149+
"id": 160894,
150+
"avatar_url": "https://avatars.githubusercontent.com/u/160894?v=3",
151+
"gravatar_id": "",
152+
"url": "https://api.github.com/users/CyberShadow",
153+
"html_url": "https://github.com/CyberShadow",
154+
"followers_url": "https://api.github.com/users/CyberShadow/followers",
155+
"following_url": "https://api.github.com/users/CyberShadow/following{/other_user}",
156+
"gists_url": "https://api.github.com/users/CyberShadow/gists{/gist_id}",
157+
"starred_url": "https://api.github.com/users/CyberShadow/starred{/owner}{/repo}",
158+
"subscriptions_url": "https://api.github.com/users/CyberShadow/subscriptions",
159+
"organizations_url": "https://api.github.com/users/CyberShadow/orgs",
160+
"repos_url": "https://api.github.com/users/CyberShadow/repos",
161+
"events_url": "https://api.github.com/users/CyberShadow/events{/privacy}",
162+
"received_events_url": "https://api.github.com/users/CyberShadow/received_events",
163+
"type": "User",
164+
"site_admin": false
165+
},
166+
"created_at": "2016-12-17T17:36:10Z",
167+
"updated_at": "2016-12-17T17:36:10Z",
168+
"body": "Which Phobos modules do you want this done on? I could do this in bulk. (After my current reduction finishes.)"
169+
},
170+
{
171+
"url": "https://api.github.com/repos/notdlang/bar/issues/comments/267779176",
172+
"html_url": "https://github.com/notdlang/bar/pull/12347#issuecomment-267779176",
173+
"issue_url": "https://api.github.com/repos/notdlang/bar/issues/12347",
174+
"id": 267779176,
175+
"user": {
176+
"login": "andralex",
177+
"id": 566679,
178+
"avatar_url": "https://avatars.githubusercontent.com/u/566679?v=3",
179+
"gravatar_id": "",
180+
"url": "https://api.github.com/users/andralex",
181+
"html_url": "https://github.com/andralex",
182+
"followers_url": "https://api.github.com/users/andralex/followers",
183+
"following_url": "https://api.github.com/users/andralex/following{/other_user}",
184+
"gists_url": "https://api.github.com/users/andralex/gists{/gist_id}",
185+
"starred_url": "https://api.github.com/users/andralex/starred{/owner}{/repo}",
186+
"subscriptions_url": "https://api.github.com/users/andralex/subscriptions",
187+
"organizations_url": "https://api.github.com/users/andralex/orgs",
188+
"repos_url": "https://api.github.com/users/andralex/repos",
189+
"events_url": "https://api.github.com/users/andralex/events{/privacy}",
190+
"received_events_url": "https://api.github.com/users/andralex/received_events",
191+
"type": "User",
192+
"site_admin": false
193+
},
194+
"created_at": "2016-12-17T18:38:17Z",
195+
"updated_at": "2016-12-17T18:38:17Z",
196+
"body": "@CyberShadow the point of this experiment is to illustrates the steps (and the ongoing maintenance) needed to take advantage of lazy imports, which have not been implemented. As of now, doing this is just giving us more maintenance to do of these lists."
197+
},
198+
{
199+
"url": "https://api.github.com/repos/notdlang/bar/issues/comments/267780746",
200+
"html_url": "https://github.com/notdlang/bar/pull/12347#issuecomment-267780746",
201+
"issue_url": "https://api.github.com/repos/notdlang/bar/issues/12347",
202+
"id": 267780746,
203+
"user": {
204+
"login": "CyberShadow",
205+
"id": 160894,
206+
"avatar_url": "https://avatars.githubusercontent.com/u/160894?v=3",
207+
"gravatar_id": "",
208+
"url": "https://api.github.com/users/CyberShadow",
209+
"html_url": "https://github.com/CyberShadow",
210+
"followers_url": "https://api.github.com/users/CyberShadow/followers",
211+
"following_url": "https://api.github.com/users/CyberShadow/following{/other_user}",
212+
"gists_url": "https://api.github.com/users/CyberShadow/gists{/gist_id}",
213+
"starred_url": "https://api.github.com/users/CyberShadow/starred{/owner}{/repo}",
214+
"subscriptions_url": "https://api.github.com/users/CyberShadow/subscriptions",
215+
"organizations_url": "https://api.github.com/users/CyberShadow/orgs",
216+
"repos_url": "https://api.github.com/users/CyberShadow/repos",
217+
"events_url": "https://api.github.com/users/CyberShadow/events{/privacy}",
218+
"received_events_url": "https://api.github.com/users/CyberShadow/received_events",
219+
"type": "User",
220+
"site_admin": false
221+
},
222+
"created_at": "2016-12-17T19:01:45Z",
223+
"updated_at": "2016-12-17T19:01:45Z",
224+
"body": "Sorry, I don't get it? Was this PR made to prove some point?\r\n\r\n> It was a major effort\r\n\r\nWell... all I'm saying is that it didn't need to be.\r\n\r\nIs there any practical reason why I shouldn't have a go at replacing module imports with selective imports throughout Phobos? Really shouldn't take much effort, just some setup and CPU time to do the reduction.\r\n\r\nI'm confused, if this change was not good, then why was it merged? And if it was good, then why shouldn't we have more of it, especially if there's an easy way to do it?"
225+
},
226+
{
227+
"url": "https://api.github.com/repos/notdlang/bar/issues/comments/267781743",
228+
"html_url": "https://github.com/notdlang/bar/pull/12347#issuecomment-267781743",
229+
"issue_url": "https://api.github.com/repos/notdlang/bar/issues/12347",
230+
"id": 267781743,
231+
"user": {
232+
"login": "andralex",
233+
"id": 566679,
234+
"avatar_url": "https://avatars.githubusercontent.com/u/566679?v=3",
235+
"gravatar_id": "",
236+
"url": "https://api.github.com/users/andralex",
237+
"html_url": "https://github.com/andralex",
238+
"followers_url": "https://api.github.com/users/andralex/followers",
239+
"following_url": "https://api.github.com/users/andralex/following{/other_user}",
240+
"gists_url": "https://api.github.com/users/andralex/gists{/gist_id}",
241+
"starred_url": "https://api.github.com/users/andralex/starred{/owner}{/repo}",
242+
"subscriptions_url": "https://api.github.com/users/andralex/subscriptions",
243+
"organizations_url": "https://api.github.com/users/andralex/orgs",
244+
"repos_url": "https://api.github.com/users/andralex/repos",
245+
"events_url": "https://api.github.com/users/andralex/events{/privacy}",
246+
"received_events_url": "https://api.github.com/users/andralex/received_events",
247+
"type": "User",
248+
"site_admin": false
249+
},
250+
"created_at": "2016-12-17T19:21:20Z",
251+
"updated_at": "2016-12-17T19:21:20Z",
252+
"body": ">Sorry, I don't get it? Was this PR made to prove some point?\r\n\r\nYes. The point was to preview the kind of setup that would have all explicit declarations.\r\n\r\n>> It was a major effort\r\n\r\n>Well... all I'm saying is that it didn't need to be.\r\n\r\nUnderstood, thanks.\r\n\r\n>Is there any practical reason why I shouldn't have a go at replacing module imports with selective imports throughout Phobos?\r\n\r\nThe replacement has no value except it adds one extra chore to maintain.\r\n\r\n>I'm confused, if this change was not good, then why was it merged? And if it was good, then why shouldn't we have more of it, especially if there's an easy way to do it?\r\n\r\nI will undo the PR."
253+
}
254+
]

‎data/payloads/github_repos_notdlang_bar_pulls_12347_commits

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,72 @@
1+
[
2+
{
3+
"sha": "e064d5664f92c4b2f0866c08f6d0290ba66825ed",
4+
"commit": {
5+
"author": {
6+
"name": "Andrei Alexandrescu",
7+
"email": "andrei@erdani.com",
8+
"date": "2016-12-16T21:54:13Z"
9+
},
10+
"committer": {
11+
"name": "Andrei Alexandrescu",
12+
"email": "andrei@erdani.com",
13+
"date": "2016-12-17T16:50:16Z"
14+
},
15+
"message": "[DEMO][DONOTPULL] Converted imports to selective imports in std.array",
16+
"tree": {
17+
"sha": "b3106d04851a8f349b6cfdcfd7c9db663edbbfcb",
18+
"url": "https://api.github.com/repos/notdlang/bar/git/trees/b3106d04851a8f349b6cfdcfd7c9db663edbbfcb"
19+
},
20+
"url": "https://api.github.com/repos/notdlang/bar/git/commits/e064d5664f92c4b2f0866c08f6d0290ba66825ed",
21+
"comment_count": 0
22+
},
23+
"url": "https://api.github.com/repos/notdlang/bar/commits/e064d5664f92c4b2f0866c08f6d0290ba66825ed",
24+
"html_url": "https://github.com/notdlang/bar/commit/e064d5664f92c4b2f0866c08f6d0290ba66825ed",
25+
"comments_url": "https://api.github.com/repos/notdlang/bar/commits/e064d5664f92c4b2f0866c08f6d0290ba66825ed/comments",
26+
"author": {
27+
"login": "andralex",
28+
"id": 566679,
29+
"avatar_url": "https://avatars.githubusercontent.com/u/566679?v=3",
30+
"gravatar_id": "",
31+
"url": "https://api.github.com/users/andralex",
32+
"html_url": "https://github.com/andralex",
33+
"followers_url": "https://api.github.com/users/andralex/followers",
34+
"following_url": "https://api.github.com/users/andralex/following{/other_user}",
35+
"gists_url": "https://api.github.com/users/andralex/gists{/gist_id}",
36+
"starred_url": "https://api.github.com/users/andralex/starred{/owner}{/repo}",
37+
"subscriptions_url": "https://api.github.com/users/andralex/subscriptions",
38+
"organizations_url": "https://api.github.com/users/andralex/orgs",
39+
"repos_url": "https://api.github.com/users/andralex/repos",
40+
"events_url": "https://api.github.com/users/andralex/events{/privacy}",
41+
"received_events_url": "https://api.github.com/users/andralex/received_events",
42+
"type": "User",
43+
"site_admin": false
44+
},
45+
"committer": {
46+
"login": "andralex",
47+
"id": 566679,
48+
"avatar_url": "https://avatars.githubusercontent.com/u/566679?v=3",
49+
"gravatar_id": "",
50+
"url": "https://api.github.com/users/andralex",
51+
"html_url": "https://github.com/andralex",
52+
"followers_url": "https://api.github.com/users/andralex/followers",
53+
"following_url": "https://api.github.com/users/andralex/following{/other_user}",
54+
"gists_url": "https://api.github.com/users/andralex/gists{/gist_id}",
55+
"starred_url": "https://api.github.com/users/andralex/starred{/owner}{/repo}",
56+
"subscriptions_url": "https://api.github.com/users/andralex/subscriptions",
57+
"organizations_url": "https://api.github.com/users/andralex/orgs",
58+
"repos_url": "https://api.github.com/users/andralex/repos",
59+
"events_url": "https://api.github.com/users/andralex/events{/privacy}",
60+
"received_events_url": "https://api.github.com/users/andralex/received_events",
61+
"type": "User",
62+
"site_admin": false
63+
},
64+
"parents": [
65+
{
66+
"sha": "19445fc71e8aabdbd42f0ad8a571a57601a5ff39",
67+
"url": "https://api.github.com/repos/notdlang/bar/commits/19445fc71e8aabdbd42f0ad8a571a57601a5ff39",
68+
"html_url": "https://github.com/notdlang/bar/commit/19445fc71e8aabdbd42f0ad8a571a57601a5ff39"
69+
}
70+
]
71+
}
72+
]

‎data/payloads/github_repos_notdlang_foo_issues_12346_comments

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
[
2+
]

‎data/payloads/github_repos_notdlang_foo_issues_12346_labels

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
[
2+
3+
]

0 commit comments

Comments
 (0)