Properly refresh and clear BugPathList

Author: Locutus18

eclipse-plugin/eclipse/cc.codechecker.eclipse.plugin/src/cc/codechecker/plugin/config/CodeCheckerContext.java

@@ -104,20 +104,22 @@ public void autoRefresh() {
 
         if (activeEditor == null) return;
 
-        CodeCheckerContext.getInstance().setActiveEditorPart(activeEditor);
+        CodeCheckerContext.getInstance().setActiveEditorPart(activeEditor,true);
     }
 
     public void cleanCache(IProject project) {
         jobRunner.getActionCacheFilter().removeAll();
         System.out.println("CLEARING CACHE");
     }
 
-    public void setActiveEditorPart(IEditorPart partRef) {
+    public void setActiveEditorPart(IEditorPart partRef,boolean refresh) {
 
         if (!(partRef.getEditorInput() instanceof IFileEditorInput)) {
             return;
         }
-
+        if (partRef == activeEditorPart && !refresh) {
+            return;
+        }
         activeEditorPart = partRef;
         IFile file = ((IFileEditorInput) partRef.getEditorInput()).getFile();
         IProject project = file.getProject();
@@ -156,6 +158,10 @@ public void setActiveEditorPart(IEditorPart partRef) {
                         rlv.onEditorChanged(project, filename);
                     }
                 }
+                if (vp.getId().equals(BugPathListView.ID)) {
+                    BugPathListView bplv = (BugPathListView) vp.getView(true);
+                    bplv.clear();
+                }
             }
         }
     }

eclipse-plugin/eclipse/cc.codechecker.eclipse.plugin/src/cc/codechecker/plugin/init/EditorPartListener.java

@@ -15,7 +15,7 @@ public void partActivated(IWorkbenchPart partRef) {
             return;
         }
         System.out.println("Editor changed");
-        CodeCheckerContext.getInstance().setActiveEditorPart((IEditorPart) partRef);
+        CodeCheckerContext.getInstance().setActiveEditorPart((IEditorPart) partRef, false);
     }
 
     @Override

eclipse-plugin/eclipse/cc.codechecker.eclipse.plugin/src/cc/codechecker/plugin/views/report/details/BugPathContentProvider.java

@@ -5,9 +5,14 @@
 import org.eclipse.jface.viewers.Viewer;
 
 import com.google.common.base.Optional;
+import com.google.common.base.Predicate;
+import com.google.common.collect.Iterables;
 
+import cc.codechecker.api.action.BugPathItem;
 import cc.codechecker.api.action.bug.path.ProblemInfo;
 
+import java.util.ArrayList;
+
 public class BugPathContentProvider implements IStructuredContentProvider {
 
     @Override
@@ -24,7 +29,14 @@ public Object[] getElements(Object inputElement) {
             @SuppressWarnings("unchecked") Optional<ProblemInfo> bp = (Optional<ProblemInfo>)
                     inputElement;
             if (bp.isPresent()) {
-                return bp.get().getItems().toArray();
+                ArrayList<BugPathItem> result = new ArrayList<>(bp.get().getItems());
+                Iterables.removeIf(result, new Predicate<BugPathItem>() {
+                    @Override
+                    public boolean apply(BugPathItem pi) {
+                        return "".equals(pi.getMessage());
+                    }
+                });
+                return result.toArray();
             }
         }
         return ArrayUtils.toArray();

eclipse-plugin/eclipse/cc.codechecker.eclipse.plugin/src/cc/codechecker/plugin/views/report/details/BugPathLabelProvider.java

@@ -1,19 +1,22 @@
 package cc.codechecker.plugin.views.report.details;
 
 import org.eclipse.jface.viewers.LabelProvider;
+import org.eclipse.core.runtime.Path;
+import org.eclipse.core.resources.IFile;
+import org.eclipse.core.resources.ResourcesPlugin;
 
 import cc.codechecker.api.action.BugPathItem;
 
 public class BugPathLabelProvider extends LabelProvider {
 
     @Override
     public String getText(Object element) {
-        BugPathItem bpi = (BugPathItem) element;
-
-        String file = bpi.getFile();
-        String[] parts = file.split("/");
 
-        return parts[parts.length - 1] + " : " + bpi.getStartPosition().getLine() + " : " + bpi.getMessage();
+        BugPathItem bpi = (BugPathItem) element;
+        Path path = new Path(bpi.getFile());
+        IFile file = ResourcesPlugin.getWorkspace().getRoot().getFile(path);
+        
+        return file.getName() + " : " + bpi.getStartPosition().getLine() + " : " + bpi.getMessage();
 
     }
 

eclipse-plugin/eclipse/cc.codechecker.eclipse.plugin/src/cc/codechecker/plugin/views/report/details/BugPathListView.java

@@ -2,8 +2,10 @@
 
 
 import org.eclipse.swt.widgets.Composite;
+import org.eclipse.swt.widgets.Display;
 import org.eclipse.ui.IActionBars;
 import org.eclipse.ui.part.*;
+
 import org.eclipse.core.resources.IProject;
 import org.eclipse.jface.action.IMenuManager;
 import org.eclipse.jface.viewers.*;
@@ -17,7 +19,7 @@ public class BugPathListView extends ViewPart {
 
     public static final String ID = "cc.codechecker.plugin.views.BugPathList";
 
-    ListViewer viewer;
+    ListViewer viewer = null;
 
     Optional<ProblemInfo> bugPath;
 
@@ -74,4 +76,13 @@ public void setName(String value) {
         setPartName(value);
     }
 
+    public void clear() {
+        Display.getDefault().asyncExec(new Runnable() {
+            public void run() {
+                viewer.setInput(null);
+                viewer.refresh();
+            }
+        });
+    }
+
 }

eclipse-plugin/service/cc.codechecker.service.api/src/main/java/cc/codechecker/api/action/bug/path/ProblemInfo.java

@@ -5,28 +5,20 @@
 import com.google.common.base.MoreObjects;
 import com.google.common.collect.ImmutableList;
 
-import java.util.List;
-import java.util.ArrayList;
 import java.util.Objects;
 
 /**
  * Contains every information about the problem
  */
 public class ProblemInfo {
 
-    private final List<BugPathItem> items;
+    private final ImmutableList<BugPathItem> items;
 
-    public ProblemInfo(List<BugPathItem> items) {
-        List<BugPathItem> result = new ArrayList<>();
-        for(BugPathItem bpi : items) {
-            if(bpi.getMessage() != "") {
-                result.add(bpi);
-            }
-        }
-        this.items = result;
+    public ProblemInfo(ImmutableList<BugPathItem> items) {
+        this.items = items;
     }
 
-    public List<BugPathItem> getItems() {
+    public ImmutableList<BugPathItem> getItems() {
         return items;
     }