Use multipart/form-data by default so all submit buttons work regardless of form data types. Override formenctype on default submit button to use url encoded when there is no file present. Do not override dev specified enctype (i.e., there is a use case for file type input with url encoding if backend just processes file name).

Author: Daniel Sheffield

examples/official-site/sqlpage/migrations/01_documentation.sql

@@ -436,6 +436,9 @@ INSERT INTO uploaded_file(name, data) VALUES(:filename, sqlpage.uploaded_file_da
 You can specify the way form data should be encoded by setting the `enctype`
 top-level property on the form.
 
+The default validation button `formenctype` is set to
+`application/x-www-form-urlencoded` unless a `file` input is present.
+
 You may also specify `formenctype` on `submit` and `image` type inputs.
 This will take precedence over the `enctype` specified on the form and is
 useful in the case there are multiple `submit` buttons on the form.

sqlpage/templates/form.handlebars

@@ -1,10 +1,13 @@
+<!--
+    For compatibility, use multipart/form-data as form enctype.
+    But for efficiency, use application/x-www-form-urlencoded on default submit button.
+-->
+{{#delay}}formenctype="{{default enctype "application/x-www-form-urlencoded"}}"{{/delay}}
 <form 
     {{#if id}}id="{{id}}"{{/if}}
     class="my-3 {{class}}"
     method="{{default method "post"}}"
     enctype="{{default enctype "multipart/form-data"}}"
-    <!-- For efficiency, change the form encoding type on the default submit button if there is no file input -->
-    {{default_submit_formenctype = default enctype "application/x-www-form-urlencoded"}}
     {{#if action}}action="{{action}}"
     {{else}}
     {{#if id}}action="#{{id}}"{{/if}}
@@ -121,21 +124,18 @@
                 </label>
             {{/if}}
             {{/if}}
-            {{#if eq type "file"}}
-                <!-- Change the form encoding type on the default submit button if there is a file input and user has not set form enctype -->
-                {{default_submit_formenctype = default enctype "multipart/form-data"}}
+            {{#if (eq type "file")}}
+                <!-- Do not override form encoding type {{flush_delayed}} -->
             {{/if}}
         {{/each_row}}
         </div>
-        {{#if (ne validate '')}} 
+        {{#if (ne validate '')}}
             <input class="btn
             btn-{{default validate_color "primary"}}
             {{#if validate_shape}} btn-{{validate_shape}} {{/if}}
             {{#if validate_outline}} btn-outline-{{validate_outline}} {{/if}}
             {{#if validate_size}} btn-{{validate_size}} {{/if}}"
-            {{#if and (has_file not (enctyp}}
-            formenctype={{default_submit_formenctype}}
-            {{/fi}}
+            {{flush_delayed}}
             type="submit"
             {{#if validate}}value="{{validate}}"{{/if}}>
         {{/if}}