From 28a428d31763dd8afa478070adb3920fbd403291 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?BRAMILLE=20S=C3=A9bastien?=
 <2752200+oktapodia@users.noreply.github.com>
Date: Fri, 22 Nov 2019 10:26:49 +0000
Subject: [PATCH] Update 3rd party builder configs

---
 .travis.yml  | 23 +++++++++--------------
 appveyor.yml |  2 ++
 2 files changed, 11 insertions(+), 14 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index c05fd7fb..acb4c95c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,6 +1,13 @@
 sudo: false
 language: cpp
 
+env:
+  matrix:
+    - TRAVIS_NODE_VERSION="8"
+    - TRAVIS_NODE_VERSION="10"
+    - TRAVIS_NODE_VERSION="12"
+    - TRAVIS_NODE_VERSION="stable"
+
 os:
   - linux
   - osx
@@ -12,12 +19,6 @@ cache:
 git:
   depth: 5
 
-env:
-  matrix:
-  - TRAVIS_NODE_VERSION="8"
-  - TRAVIS_NODE_VERSION="10"
-  - TRAVIS_NODE_VERSION="stable"
-
 addons:
   apt:
     sources:
@@ -31,11 +32,9 @@ addons:
       - gcc-4.8
 
 before_install:
-  # reinstall latest nvm
   - rm -rf ~/.nvm && git clone https://github.com/creationix/nvm.git ~/.nvm && (cd ~/.nvm && git checkout `git describe --abbrev=0 --tags`) && source ~/.nvm/nvm.sh
   - nvm install $TRAVIS_NODE_VERSION
   - PATH=$PATH:`pwd`/node_modules/.bin
-
   # print versions
   - node --version
   - npm --version
@@ -44,16 +43,12 @@ before_install:
   - if [[ $TRAVIS_OS_NAME == "linux" ]]; then export CXX=g++-4.8; fi
   - $CXX --version
 
-before_script:
-  # Start xvfb
-  - if [[ $TRAVIS_OS_NAME == "linux" ]]; then export DISPLAY=:99.0; fi
-  - if [[ $TRAVIS_OS_NAME == "linux" ]]; then sh -e /etc/init.d/xvfb start; fi
-
 install:
   - npm install
 
 script:
-  - npm test
+  - if [ "$TRAVIS_OS_NAME" = "osx" ]; then npm test; fi
+  - if [ "$TRAVIS_OS_NAME" = "linux" ]; then xvfb-run npm test; fi
 
 after_success:
   - if [[ $TRAVIS_TAG != "" ]]; then npm run prebuild -- -u $GITHUB_TOKEN; fi
diff --git a/appveyor.yml b/appveyor.yml
index 4569a14b..588f4f6e 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -5,6 +5,8 @@ environment:
   matrix:
   # node.js
     - nodejs_version: "8"
+    - nodejs_version: "10"
+    - nodejs_version: "12"
     - nodejs_version: "Stable"
 
 cache: