Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typescipt ControlChangeMessageEvent includes { channel: number } which is actually undefined. #427

Closed
xinaesthete opened this issue Aug 6, 2024 · 1 comment
Closed

typescipt ControlChangeMessageEvent includes { channel: number } which is actually undefined. #427

xinaesthete opened this issue Aug 6, 2024 · 1 comment
Assignees
@djipco
Labels
Context: TypeScript Problem specific to TypeScript Type: documentation Issue that highlights an imprecision in the documentation

Comments

@xinaesthete
Copy link

Description
This appears with auto-completion etc and can lead to writing something like e.channel === channel rather than e.message.channel === channel.

Environment:
"webmidi": "^3.1.9" as freshly installed via npm.
Browser ESM, Vite, TS, React etc.
@djipco djipco self-assigned this Aug 6, 2024
djipco pushed a commit that referenced this issue Aug 6, 2024
Fix defs to properly reflect properties (issue #427)
e34405c
@djipco
Copy link
Owner

djipco commented Aug 6, 2024

Good catch! Thanks for reporting. Fixed in release 3.1.10.

@djipco djipco closed this as completed Aug 6, 2024
@djipco djipco added Type: documentation Issue that highlights an imprecision in the documentation Context: TypeScript Problem specific to TypeScript labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djipco djipco

Labels
Context: TypeScript Problem specific to TypeScript Type: documentation Issue that highlights an imprecision in the documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xinaesthete @djipco