Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rawValue does not work for channelAfterTouch #401

Closed
woppa684 opened this issue Dec 16, 2023 · 1 comment
Closed

rawValue does not work for channelAfterTouch #401

woppa684 opened this issue Dec 16, 2023 · 1 comment
Assignees
@djipco
Labels
Type: bug Verified malfunction

Comments

@woppa684
Copy link

As can be seen here, the value is always multiplied by 127

https://github.com/djipco/webmidi/blob/c8ab29cac632179f2e0f0d255c56b12d90ecaf16/src/OutputChannel.js#L1138C9-L1138C35
@djipco djipco self-assigned this Dec 16, 2023
djipco pushed a commit that referenced this issue Dec 16, 2023
Fix raw values not being properly sent in Output.channelAfterTouch() (#…
19faf78 
…401)
@djipco djipco added the Type: bug Verified malfunction label Dec 16, 2023
@djipco
Copy link
Owner

djipco commented Dec 16, 2023

Thank you for reporting this. It has been fixed in release 3.1.8 which is available on NPM right now.

@djipco djipco closed this as completed Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djipco djipco

Labels
Type: bug Verified malfunction
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djipco @woppa684