Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note duration ignored in channel.playNote #337

Closed
tobyhede opened this issue Feb 1, 2023 · 1 comment
Closed

Note duration ignored in channel.playNote #337

tobyhede opened this issue Feb 1, 2023 · 1 comment
Assignees
Labels
Type: bug Verified malfunction

Comments

@tobyhede
Copy link
Contributor

tobyhede commented Feb 1, 2023

When using playNote with a note containing a duration value, the duration is not used.

const note = new Note(value, { attack, duration })
channel.playNote(note);

I think I've tracked the issue to a Line 724 OutputChannel.js

The implementation of playNote accepts an options object and uses a duration value in this object:

if (options.duration > 0 && isFinite(String(options.duration).trim() || NaN)) {

@djipco djipco self-assigned this Feb 1, 2023
@djipco djipco added the Type: bug Verified malfunction label Feb 3, 2023
@djipco
Copy link
Owner

djipco commented Feb 3, 2023

This has been fixed in release 3.1.4.
Thank you so much for reporting the problem.

@djipco djipco closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug Verified malfunction
Projects
None yet
Development

No branches or pull requests

2 participants