API rewrite + 0.6.0 compatibility #46
Conversation
Utilizing native Vault API—express server now only acts as a passthrough to bypass CORs for login methods.
callVaultApi has some assumptions that are not valid during login, specifically the presence of the vault_addr and vault_token variables in localstorage. These two variables are not yet available from the login screen.
Secrets url path
- Currently does not handle case where secret does not exist, errors thrown all over. Need to put in some kind of 404 page or error message when trying to navigate to a nonexistent secret
|
Looks good mate. Working on the last bits of token management, I'm almost 1:1 feature parity with the vault API. Can we have a |
|
I was actually thinking about that over the weekend @msessa-cotd, though after some thought, the idea started to lose purpose for me. I say this because users should be using versioned images in their deployments. If they don't, they'll be using Feature branch --> local development The only benefit I would see a |
|
Makes sense @djenriquez. I was worried the project direction was to try to keep master stable but your comment clarifies that. |
/sys/mountsin version 0.6.0 which affected displaying generic backends@alexunwin @Lucretius @msessa-cotd I’d like to release 0.2.0 after this PR is merged, PTAL.