fix: Update zip() function argument updated from strict=False to strict=True

Author: DhavalGojiya

pysolr.py

@@ -802,7 +802,7 @@ def suggest_terms(self, fields, prefix, handler="terms", **kwargs):
         # in Solr 3+ the value of terms is a dict of field name and a flat list of
         # value, count pairs: {"field_name": ["dance", 23, "dancers", 10, …]}
         if isinstance(terms, (list, tuple)):
-            terms = dict(zip(terms[0::2], terms[1::2], strict=False))
+            terms = dict(zip(terms[0::2], terms[1::2], strict=True))
 
         for field, values in terms.items():
             tmp = []

tests/test_client.py

@@ -833,7 +833,7 @@ def test_field_update_inc(self):
 
         updatedDocs = self.solr.search("doc")
         self.assertEqual(len(updatedDocs), 3)
-        for originalDoc, updatedDoc in zip(originalDocs, updatedDocs, strict=False):
+        for originalDoc, updatedDoc in zip(originalDocs, updatedDocs, strict=True):
             self.assertEqual(len(updatedDoc.keys()), len(originalDoc.keys()))
             self.assertEqual(updatedDoc["popularity"], originalDoc["popularity"] + 5)
             # TODO: change this to use assertSetEqual:
@@ -856,7 +856,7 @@ def test_field_update_set(self):
 
         updatedDocs = self.solr.search("doc")
         self.assertEqual(len(updatedDocs), 3)
-        for originalDoc, updatedDoc in zip(originalDocs, updatedDocs, strict=False):
+        for originalDoc, updatedDoc in zip(originalDocs, updatedDocs, strict=True):
             self.assertEqual(len(updatedDoc.keys()), len(originalDoc.keys()))
             self.assertEqual(updatedDoc["popularity"], updated_popularity)
             # TODO: change this to use assertSetEqual:
@@ -894,7 +894,7 @@ def test_field_update_add(self):
 
         updatedDocs = self.solr.search("multivalued")
         self.assertEqual(len(updatedDocs), 2)
-        for originalDoc, updatedDoc in zip(originalDocs, updatedDocs, strict=False):
+        for originalDoc, updatedDoc in zip(originalDocs, updatedDocs, strict=True):
             self.assertEqual(len(updatedDoc.keys()), len(originalDoc.keys()))
             self.assertEqual(
                 updatedDoc["word_ss"], originalDoc["word_ss"] + ["epsilon", "gamma"]
@@ -995,7 +995,7 @@ def test_can_handles_default_commit_policy(self):
         expected_commits = [False, True, False]
         commit_arg = [False, True, None]
 
-        for expected_commit, arg in zip(expected_commits, commit_arg, strict=False):
+        for expected_commit, arg in zip(expected_commits, commit_arg, strict=True):
             self.solr.add([{"id": "doc_6", "title": "Newly added doc"}], commit=arg)
             args, _ = self.solr._send_request.call_args
             committing_in_url = "commit" in args[1]
@@ -1201,7 +1201,7 @@ def test_can_handles_default_commit_policy(self):
         expected_commits = [False, True, True]
         commit_arg = [False, True, None]
 
-        for expected_commit, arg in zip(expected_commits, commit_arg, strict=False):
+        for expected_commit, arg in zip(expected_commits, commit_arg, strict=True):
             self.solr.add(self.docs, commit=arg)
             args, _ = self.solr._send_request.call_args
             committing_in_url = "commit" in args[1]