take api dir as program argument, perhaps contribute this code to the introprog repo?

[bjornregnell]

Many thanks for this "life-saving" patch!

I think it would be good to take the api dir as a program argument so you can run this from anywhere.

I'd also like to include this pacth in introprog for students to find it more easily and also for maintaining updates to deps etc. so I'm wondering if you would be willing to contribute this code to here? https://github.com/lunduniversity/introprog/tree/master/util

If you add this single code file to introprog util folder by a PR so you get the cred in history, then I can update deps and fix program arguments etc if you prefer so?

[bjornregnell]

Also it seems like you are actually not using dep commons-io or jsoup ?

[dixine55]

Also it seems like you are actually not using dep commons-io or jsoup ?

Indeed it doesn't. Originally when I was looking into solving the problem I looked up some possible suitable libraries, but forgot to remove them..

As for contributing the code to introprog I'd be glad to do so if you want to improve it further.

For now I've added functionality to pass the directory as an argument and prompt the user to verify if the directory is correct, although, it might be better to save all the html files that will be modified in a list and prompt the user if they want to proceed before modifiying as we go through all subdirectories in the given directory too.

[bjornregnell]

Yes, if you could change it to not "pollute" local dirs with files it would be good. Another idea: Perhaps you could make this a lib without a main that is released here and then in readme of this repo state how to make a simple main program, similar to:

//> using scala 3.6.3
//> using dep "scaladocpatcher:1.0.0,url=https://github.com/dixine55/Scaladoc-Local-Version-Patcher/releases/download/v1.0.0/scaladocpatcher-1.0.0.jar"

// run with: `scala run scaladocpatcher-main.scala ~/path-to/api`

@main def hello(dir: String) = scaladocpatcher.patch(dir)

And also offer that file in each release as scaladocpatcher-main.scala

What do you think?

(Alternatively if you don't want to maintain/update this util then you could contribute to introprog under the util dir and I will take care of updates as long as it is needed and I'm in charge of programming course at Lund Univ)