Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod diagnostics improvements #3134

Open
tgeoghegan opened this issue May 14, 2024 · 0 comments
Open

mod diagnostics improvements #3134

tgeoghegan opened this issue May 14, 2024 · 0 comments

Comments

@tgeoghegan
Copy link
Contributor

With #3129, we now have the capability of dumping descriptions of events to files. This could be useful for debugging a variety of things where logs aren't suitable so I think we will want to hang on to this feature indefinitely. The module I cobbled together could use some improvements:

  • fix the todo!()s in the deserialize() implementations
  • see if we can unify the nearly identical serialize impls for AggregationJobId and TaskId (we might consider adding a serde feature to janus_messages that derives Serialize/Deserialize right there
  • make writing of events even more async. Right now, whatever path in a request handler triggered the writing of an event will block until the whole thing is written to a file. It'd be nice if we could ship that off to some async context and let the request handler return whatever error the client is going to get.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant