Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decouple SelectFeatures and store update #7

Closed
mariogiampieri opened this issue Jul 22, 2024 · 1 comment · Fixed by #8
Closed

decouple SelectFeatures and store update #7

mariogiampieri opened this issue Jul 22, 2024 · 1 comment · Fixed by #8
Assignees
@mariogiampieri
Labels
enhancement New feature or request frontend
Milestone
Midpoint

Comments

@mariogiampieri
Copy link
Collaborator

Right now, features are updated in the maplibre map object, and then in the zustand store, within SelectFeatures. These should be decoupled such that the map object is updated while painting occurs, and setting the store happens onMouseUp or something similar to get rid of the need to debounce.
@mariogiampieri mariogiampieri added the enhancement New feature or request label Jul 22, 2024
@mariogiampieri mariogiampieri self-assigned this Jul 22, 2024
@mariogiampieri mariogiampieri linked a pull request Jul 22, 2024 that will close this issue
Feat/refactor dispatcher #8
Merged
2 tasks
@mariogiampieri mariogiampieri mentioned this issue Jul 28, 2024
Merged
2 tasks
@mariogiampieri mariogiampieri added this to the Midpoint milestone Aug 1, 2024
@mariogiampieri
Copy link
Collaborator Author

closed by #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariogiampieri mariogiampieri

Labels
enhancement New feature or request frontend
Projects
None yet
Milestone
Midpoint
Development

Successfully merging a pull request may close this issue.

Feat/refactor dispatcher districtr/districtr-v2
1 participant
@mariogiampieri