platform-specific process killing

Author: chicoxyzzy

.github/workflows/build.yml

@@ -17,6 +17,9 @@ env:
 jobs:
   lint:
     runs-on: ubuntu-latest
+    concurrency:
+      group: tests-${{ github.workflow }}-${{ github.event.number || github.ref }}
+      cancel-in-progress: true
     permissions:
       id-token: write
       contents: read

cli/run.go

@@ -205,9 +205,7 @@ Run 'dispatch help run' to learn about Dispatch sessions.`, BridgeSession)
 							s = os.Kill
 						}
 						if cmd.Process != nil && cmd.Process.Pid > 0 {
-							// Sending the signal to -pid sends it to all processes
-							// in the process group.
-							_ = syscall.Kill(-cmd.Process.Pid, s.(syscall.Signal))
+							killProcess(cmd.Process, s.(syscall.Signal))
 						}
 					}
 				}

cli/run_darwin.go

@@ -1,7 +1,16 @@
 package cli
 
-import "syscall"
+import (
+	"os"
+	"syscall"
+)
 
 func setSysProcAttr(attr *syscall.SysProcAttr) {
 	attr.Setpgid = true
 }
+
+func killProcess(process *os.Process, signal os.Signal) {
+	// Sending the signal to -pid sends it to all processes
+	// in the process group.
+	_ = syscall.Kill(-process.Pid, signal.(syscall.Signal))
+}

cli/run_linux.go

@@ -1,8 +1,17 @@
 package cli
 
-import "syscall"
+import (
+	"os"
+	"syscall"
+)
 
 func setSysProcAttr(attr *syscall.SysProcAttr) {
 	attr.Setpgid = true
 	attr.Pdeathsig = syscall.SIGTERM
 }
+
+func killProcess(process *os.Process, signal os.Signal) {
+	// Sending the signal to -pid sends it to all processes
+	// in the process group.
+	_ = syscall.Kill(-process.Pid, signal.(syscall.Signal))
+}

cli/run_windows.go

@@ -0,0 +1,7 @@
+package cli
+
+import "os"
+
+func killProcess(process *os.Process, _ os.Signal) {
+	process.Kill()
+}