fix(WebSocketShard): handle initial connect being a resume #9549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vladfrangu
reviewed
May 8, 2023
Codecov Report
@@ Coverage Diff @@
## main #9549 +/- ##
==========================================
+ Coverage 58.38% 58.57% +0.19%
==========================================
Files 227 226 -1
Lines 14856 14806 -50
Branches 1133 1132 -1
==========================================
Hits 8673 8673
+ Misses 6143 6093 -50
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
iCrawl
approved these changes
May 8, 2023
vladfrangu
approved these changes
May 11, 2023
Jiralite
approved these changes
May 11, 2023
kyranet
approved these changes
May 11, 2023
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-guide-git-fix-ws-initial-resume-discordjs.vercel.app/guide/home/introduction |
Idris1401
pushed a commit
to Idris1401/discord.js
that referenced
this pull request
May 12, 2023
…#9549) * fix(WebSocketShard): handle initial connect being a resume * chore: remove leftover --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Closes #9548
Status and versioning classification: