types(ModalSubmitFields): components is an array

[ImRodry]

Please describe the changes this PR makes and why it should be merged:

This PR simply fixes an issue in ModalSubmitFields#components as it wasn't marked as an array and instead was simply an action row

Status and versioning classification:

• Code changes have been tested against the Discord API, or there are no code changes
• I know how to update typings and have done so, or typings don't need updating

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
discord-js	⬜️ Ignored (Inspect)			Apr 16, 2023 10:47pm
discord-js-guide	⬜️ Ignored (Inspect)			Apr 16, 2023 10:47pm

[ImRodry]

Oh cool you're using teams now, just fyi github only officially assigns 2 members of the team at a time despite you all appearing on the side

[kyranet]

Upon further inspection, I just noticed there's a mismatch in the types used. In the JS code, we use a custom interface (documented here):

discord.js/packages/discord.js/src/structures/ModalSubmitFields.js

Lines 12 to 16 in e04801b

	/**
	* The components within the modal
	* @type {ActionRowModalData[]}
	*/
	this.components = components;

ActionRowModalData is defined in the typings here:

discord.js/packages/discord.js/typings/index.d.ts

Lines 2218 to 2221 in e04801b

	export interface ActionRowModalData {
	type: ComponentType.ActionRow;
	components: ModalData[];
	}

However, this is using ActionRow<ModalActionRowComponent> instead.

[ImRodry]

I didn't notice but yeah the type is wrong however I don't think that one is right either because that one technically indicates that you can chain components.components infinitely, despite the actual TextInputComponent object coming with a components property set to undefined. Should I just use that type and ignore this?

[kyranet]

The types should match what the JS code is, unless the JS code is somehow wrong and has been for a year.

[ImRodry]

The only thing "wrong" about the JS code is the fact that components is set as undefined on text input objects. I'll try to modify the types a little to match that

[ImRodry]

Also I know how to fix that issue, can I include that in this PR?

[ImRodry]

Pushed both the types change and a small change to the transformComponent function that should get rid of all the undefined properties to align it with the data returned by the API and the TS types. If you want me to remove that commit or move it to a different PR lmk

Stale