-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deprecate ActionRow.from()
#8504
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simply adding this after the class will do the trick:
const { deprecate } = require('node:util');
// ...
ActionRow.from = deprecate(
ActionRow.from,
'ActionRow.from() is deprecated. Use ActionRowBuilder.from() instead.',
);
Note the change of the deprecation message to be consistent with the Formatters
class.
Codecov Report
@@ Coverage Diff @@
## main #8504 +/- ##
==========================================
- Coverage 89.37% 86.29% -3.09%
==========================================
Files 66 87 +21
Lines 7343 8362 +1019
Branches 899 1105 +206
==========================================
+ Hits 6563 7216 +653
- Misses 776 1103 +327
- Partials 4 43 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Please describe the changes this PR makes and why it should be merged:
This PR adds a depreciation warning for
ActionRow.from()
Status and versioning classification: