-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove ActionRow.from()
#8502
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Doesn't this go against the RFC? EDIT: Misread, thought this was about builders |
Codecov Report
@@ Coverage Diff @@
## main #8502 +/- ##
===========================================
+ Coverage 59.54% 86.29% +26.74%
===========================================
Files 12 87 +75
Lines 1466 8362 +6896
Branches 87 1105 +1018
===========================================
+ Hits 873 7216 +6343
- Misses 592 1103 +511
- Partials 1 43 +42
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Can you make a pull request to emit a deprecation warning to use the |
I just checked the |
That would be because of #8504. The communication wasn't good here, but thank you for pointing it out. |
Please describe the changes this PR makes and why it should be merged:
This PR removes
ActionRow.from()
since it contains incorrect docs, has no types and shouldn't be in a component.Status and versioning classification: