Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WebSocketShard#destroy): wait for close and cleanup listeners #8479

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

didinele
Copy link
Member

@didinele didinele commented Aug 12, 2022

Please describe the changes this PR makes and why it should be merged:
This is yet another attempt at fixing the exact same problem as #8399 and #8405

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Aug 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Aug 16, 2022 at 3:31PM (UTC)

@vercel vercel bot temporarily deployed to Preview August 12, 2022 12:49 Inactive
packages/ws/src/ws/WebSocketShard.ts Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #8479 (a937d0c) into main (a1dddd6) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

❗ Current head a937d0c differs from pull request most recent head effd55b. Consider uploading reports for the commit effd55b to get more accurate results

@@            Coverage Diff             @@
##             main    #8479      +/-   ##
==========================================
- Coverage   86.49%   86.29%   -0.21%     
==========================================
  Files          87       87              
  Lines        8339     8297      -42     
  Branches     1104     1104              
==========================================
- Hits         7213     7160      -53     
- Misses       1083     1094      +11     
  Partials       43       43              
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <ø> (ø)
proxy 73.28% <ø> (ø)
rest 92.53% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 64.08% <ø> (ø)
ws 59.47% <0.00%> (-0.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/ws/src/ws/WebSocketShard.ts 22.41% <0.00%> (-0.45%) ⬇️
packages/ws/src/ws/WebSocketManager.ts 98.54% <0.00%> (-0.06%) ⬇️
packages/ws/src/utils/utils.ts 100.00% <0.00%> (ø)
packages/collection/src/collection.ts 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vercel vercel bot temporarily deployed to Preview August 16, 2022 15:31 Inactive
@kodiakhq kodiakhq bot merged commit acdafe6 into discordjs:main Aug 16, 2022
@didinele didinele deleted the fix/ws-destroy branch August 16, 2022 16:32
@iCrawl iCrawl modified the milestones: ws v1, ws v1.1 Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants