-
-
Notifications
You must be signed in to change notification settings - Fork 4k
feat: create 'GuildTemplate' & add 'Client#fetchGuildTemplate()' #4906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
NotSugden
suggested changes
Oct 15, 2020
NotSugden
suggested changes
Oct 15, 2020
bc176b5 to
183080e
Compare
NotSugden
suggested changes
Nov 14, 2020
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
json error code 10057 unknown guild template could be added to this PR https://discord.com/developers/docs/topics/opcodes-and-status-codes#json
Contributor
Author
|
Closing this PR since its being superseded by #4907 and the referenced API docs PR on there has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataResolver#resolveGuildTemplateCode()to resolve template URLsDataResolver#resolveCode()to reuse code for the above and theresolveInviteCodemethodGuildTemplatestructure with acreateGuildmethod to add support for thePOST /guilds/templates/:template_codeendpointClient#fetchGuildTemplate()to support for theGET /guilds/templates/:template_codeendpointHere's a snippet of how I tested these changes
Status
Semantic versioning classification: