fix(Rest): resolved a regression, added retried AbortError

[kyranet]

Please describe the changes this PR makes and why it should be merged:

#4835 introduced a regression in 4xx errors, the following chunks of code are not identical - the old one rejected with DiscordAPIError if there was a 4xx error, but the new one throws, and then re-throws but as a HTTPError:

discord.js/src/rest/RequestHandler.js

Lines 167 to 175 in 7b38f46

	try {
	const data = await parseResponse(res);
	if (res.status >= 400 && res.status < 500) {
	return reject(new DiscordAPIError(request.path, data, request.method, res.status));
	}
	return null;
	} catch (err) {
	return reject(new HTTPError(err.message, err.constructor.name, err.status, request.method, request.path));
	}

discord.js/src/rest/RequestHandler.js

Lines 150 to 158 in 169d4c3

	try {
	const data = await parseResponse(res);
	if (res.status >= 400 && res.status < 500) {
	throw new DiscordAPIError(request.path, data, request.method, res.status);
	}
	return null;
	} catch (err) {
	throw new HTTPError(err.message, err.constructor.name, err.status, request.method, request.path);
	}

My apologies for anyone affected, even though nobody reported this issue (yet) since the names and properties are nearly identical for error handlers that don't check for instanceof. But the good news, retried AbortErrors!

Stack Traces and Types

Running the following code, and using @klasa/type to retrieve the output's type in eval:

message.channel.send('a'.repeat(2001));

Before this patch:

DiscordAPIError: Invalid Form Body
content: Must be 2000 or fewer in length.
    at RequestHandler.execute (.../node_modules/discord.js/src/rest/RequestHandler.js:157:13)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async RequestHandler.push (.../node_modules/discord.js/src/rest/RequestHandler.js:39:14)
    at async Object.eval (.../dist/commands/System/Admin/eval.js:74:26)
    at async Object.run (.../dist/commands/System/Admin/eval.js:19:49)
    at async default_1.runCommand (.../dist/monitors/commandHandler.js:58:38)
    ...

Type:

Promise<HTTPError>

The type is incorrect, the error thrown must be an instance of DiscordAPIError if it's related to an error thrown from the API.

After this patch:

DiscordAPIError: Invalid Form Body
content: Must be 2000 or fewer in length.
    at RequestHandler.execute (.../node_modules/discord.js/src/rest/RequestHandler.js:154:13)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async RequestHandler.push (.../node_modules/discord.js/src/rest/RequestHandler.js:39:14)
    at async Object.eval (.../dist/commands/System/Admin/eval.js:74:26)
    at async Object.run (.../dist/commands/System/Admin/eval.js:19:49)
    at async default_1.runCommand (.../dist/monitors/commandHandler.js:58:38)
    ...

Type:

Promise<DiscordAPIError>

With this patch, the error's type is the correct one.

---

Fixes #3471

Status

• Code changes have been tested against the Discord API, or there are no code changes
• I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

• This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
• This PR only includes non-code changes, like changes to documentation, README, etc.

[neofutur]

please push this, we badly need a fix for #3471

[kyranet]

There's no rush, giving time before merging helps getting more eyes on it, which can lead to more people trying it out. The more, the better, as they can find issues we didn't.

This PR will be included in the 12.4.0 release, that's for sure :)

[flav-code]

i have this problem