feat: trigger userUpdate on GUILD_MEMBER_UPDATE #4697
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
The
USER_UPDATE
gateway event only triggers when the bot's user itself is updated, but discord.js's userUpdate event triggers when any user known user is updated.Currently, the userUpdate event triggers on the
USER_UPDATE
gateway event as well as thePRESENCE_UPDATE
event.However, due to the addition of Intents, Discord now also sends user updates in the
GUILD_MEMBER_UPDATE
event:(from discord/discord-api-docs#1307 (comment))
This PR updates discord.js to also trigger the userUpdate event on the
GUILD_MEMBER_UPDATE
events, for users who are using theGUILD_MEMBERS
intent but not theGUILD_PRESENCES
event. I copied the relevant code from thePresenceUpdate
action to theGUILD_MEMBER_UPDATE
handler.It also updates documentation to clarify which events trigger userUpdate.
resolves #4279, related to #4169
Status
Semantic versioning classification: