Skip to content

feat(GuildMemberManager#prune): roles query param #4142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 14, 2020
Merged

feat(GuildMemberManager#prune): roles query param #4142

merged 12 commits into from
Aug 14, 2020

Conversation

@Fyko
Copy link
Contributor

@Fyko Fyko commented Apr 30, 2020

Please describe the changes this PR makes and why it should be merged:
This PR adds support for discord/discord-api-docs#1563.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

izexi
izexi reviewed Apr 30, 2020
View reviewed changes
Copy link
Contributor

@izexi izexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RoleResolvable could be used instead of a Snowflake

Fyko and others added 2 commits April 30, 2020 10:03
@Fyko @izexi
feat: allow roles to be a role resolvable
aed59cd 
Co-authored-by: izexi <43889168+izexi@users.noreply.github.com>
@Fyko @izexi
typings: roles option as RoleResolvable
dbcf986 
Co-authored-by: izexi <43889168+izexi@users.noreply.github.com>
@Fyko Fyko marked this pull request as draft April 30, 2020 16:27
@Fyko Fyko mentioned this pull request Apr 30, 2020
Merged
5 tasks
NotSugden
NotSugden reviewed May 3, 2020
View reviewed changes
@vladfrangu
Copy link
Member

vladfrangu commented Aug 11, 2020

This PR needs an update as Discord now requires query params for GET but JSON params for POST..

@Fyko
Copy link
Contributor Author

Fyko commented Aug 13, 2020

This PR needs an update as Discord now requires query params for GET but JSON params for POST..

Implemented with 2c86024

@Fyko Fyko marked this pull request as ready for review August 13, 2020 22:20
NotSugden
NotSugden reviewed Aug 13, 2020
View reviewed changes
Fyko and others added 2 commits August 13, 2020 17:04
@Fyko @NotSugden
fix: send body correctly
3fa2e71 
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
@Fyko
fix: remove redundant if statement
9d35a18
vladfrangu
vladfrangu requested changes Aug 13, 2020
View reviewed changes
@iCrawl iCrawl requested a review from vladfrangu August 14, 2020 17:39
vladfrangu
vladfrangu requested changes Aug 14, 2020
View reviewed changes
vladfrangu and others added 2 commits August 14, 2020 21:02
@iCrawl iCrawl merged commit f1194af into discordjs:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

+2 more reviewers

@NotSugden NotSugden NotSugden left review comments

@izexi izexi izexi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Fyko @vladfrangu @iCrawl @kyranet @NotSugden @izexi @SpaceEEC