feat(Util): add missing colors to docs #3843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the following colors, which were missing from the docs: - BLURPLE - GREYPLE - DARK_BUT_NOT_BLACK - NOT_QUITE_BLACK
Contributor
|
Well based on #2729 these are some hidden memes/easter eggs that you can only find by digging into the source code :) |
Contributor
Author
|
Oh! Well, they're all official Discord Colors, so if that still stands then I imagine all of them would be Easter eggs. Still, I'll wait for a member to close this if they're intentionally undocumented. |
Member
|
The documented colors are based on the color picker in the role ui in the app. The undocumented ones are based on discord's branding guidelines (which you linked to). |
Contributor
Author
|
Right, so should the Discord banding colors be documented, or should they be kept undocumented as a secret of some sort? |
NotSugden
suggested changes
Mar 18, 2020
iCrawl
approved these changes
Aug 11, 2020
iCrawl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following colors which were missing from the docs (as noted here):
Status
Semantic versioning classification: