-
-
Notifications
You must be signed in to change notification settings - Fork 4k
add channel categories #1727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add channel categories #1727
Conversation
| this.position = data.position; | ||
|
|
||
| /** | ||
| * The ID of the category parent of this channel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snowflake*
| * Creates a new channel in the guild. | ||
| * @param {string} name The name of the new channel | ||
| * @param {string} type The type of the new channel, either `text` or `voice` | ||
| * @param {Object} [options={}] Options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...it is optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
he made it not optional in the docs, see the lines after it @appellation
also he just made it optional, and I probably put the wrong line for review ._.
PgBiel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok
…rd.js into channel-categories
|
Is there any documentation for this? |
Please describe the changes this PR makes and why it should be merged:
wowee channel categories very exiciting
Semantic versioning classification: