Skip to content

Conversation

@devsnek
Copy link
Member

@devsnek devsnek commented Jul 28, 2017

Please describe the changes this PR makes and why it should be merged:
wowee channel categories very exiciting

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@devsnek devsnek changed the title add channel categories add channel categories, and rewrite channel type handling Jul 28, 2017
this.position = data.position;

/**
* The ID of the category parent of this channel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snowflake*

* Creates a new channel in the guild.
* @param {string} name The name of the new channel
* @param {string} type The type of the new channel, either `text` or `voice`
* @param {Object} [options={}] Options
Copy link
Contributor

@PgBiel PgBiel Aug 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be optional?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...it is optional?

Copy link
Contributor

@PgBiel PgBiel Aug 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

he made it not optional in the docs, see the lines after it @appellation

also he just made it optional, and I probably put the wrong line for review ._.

Copy link
Contributor

@PgBiel PgBiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

@devsnek devsnek changed the title add channel categories, and rewrite channel type handling add channel categories Sep 9, 2017
@iCrawl iCrawl merged commit c46c092 into discordjs:master Sep 9, 2017
@devsnek devsnek deleted the channel-categories branch September 9, 2017 14:35
@codingJWilliams
Copy link

Is there any documentation for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants