fix(Message): update pinnable to check for migrated guilds
#11189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This comment was marked as outdated.
This comment was marked as outdated.
vakiliner
reviewed
Oct 21, 2025
sdanialraza
force-pushed
the
fix/update-pinnable-migrated
branch
2 times, most recently
from
59f3ace to
03bb75e
Compare
Jiralite
reviewed
Oct 23, 2025
Qjuh
previously requested changes
Oct 23, 2025
sdanialraza
force-pushed
the
fix/update-pinnable-migrated
branch
from
03bb75e to
01cf8f0
Compare
sdanialraza
force-pushed
the
fix/update-pinnable-migrated
branch
from
01cf8f0 to
b424b6f
Compare
advaith1
previously requested changes
Oct 24, 2025
Contributor
advaith1
left a comment
advaith1
left a comment
There was a problem hiding this comment.
The migration has nothing to do with which permissions are usable - if you have either Manage Messages or Pin Messages you can pin. (as long as you also have read message history)
Member
The notice in permissions UI in the client seems to state differently. That's the whole point of that new separate permission afaict. |
Contributor
|
on that date manage messages will stop allowing pinning. that is separate from the guild feature |
Jiralite
requested changes
Oct 24, 2025
Jiralite
approved these changes
Oct 24, 2025
github-project-automation
bot
moved this from Review in Progress
to Review Approved
in discord.js
vladfrangu
reviewed
Oct 24, 2025
vladfrangu
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Resolves #11188