chore(WebSocketShard): improve zlib-sync errors #10808
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Qjuh
approved these changes
May 2, 2025
almeidx
reviewed
May 2, 2025
Comment on lines
+62
to
+71
| enum ZlibErrorCodes { | ||
| Z_NEED_DICT = 2, | ||
| Z_STREAM_END = 1, | ||
| Z_ERRNO = -1, | ||
| Z_STREAM_ERROR = -2, | ||
| Z_DATA_ERROR = -3, | ||
| Z_MEM_ERROR = -4, | ||
| Z_BUF_ERROR = -5, | ||
| Z_VERSION_ERROR = -6, | ||
| } |
There was a problem hiding this comment.
Having these hardcoded here is not ideal.. Especially since zlib-sync exports each of these codes as constants
We could import them and construct this object using them
https://github.com/abalabahaha/zlib-sync/blob/7f1b404ba9e1bb9af1f47ca395f33e4fdfc2299c/src/zlib_sync.cc#L220-L228
(This would imply moving this object creation into the unpackMessage method as that's where zlib is being imported)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
The current error thrown from
zlib-syncisn't great, and doesn't match what errors fromnode:zliblook like. This brings them more in line withnode:zliberrors.Status and versioning classification: