feat: Voice Channel Effect Send #10318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10318 +/- ##
=======================================
Coverage 38.16% 38.16%
=======================================
Files 239 239
Lines 15500 15500
Branches 1369 1369
=======================================
Hits 5915 5915
Misses 9570 9570
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sdanialraza
reviewed
Oct 9, 2024
Co-authored-by: Danial Raza <danialrazafb@gmail.com>
sdanialraza
approved these changes
Oct 9, 2024
vladfrangu
approved these changes
Nov 4, 2024
SpaceEEC
approved these changes
Nov 13, 2024
kyranet
approved these changes
Nov 14, 2024
Jiralite
added a commit
that referenced
this pull request
Nov 15, 2024
* feat: Voice Channel Send Effects (#9288) * feat: add soundboard fields * chore: address TODO * docs: volume is a closed interval * types: use `GatewayVoiceChannelEffectSendDispatchData` * refactor: prefer getting from cache * fix: correctly access cache Co-authored-by: Danial Raza <danialrazafb@gmail.com> --------- Co-authored-by: Danial Raza <danialrazafb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
VoiceChannelEffectSendevent discord-api-types#739Status and versioning classification: