Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of new Replies functionality #5071

Closed
tinfoilboy opened this issue Dec 1, 2020 · 6 comments · Fixed by #4874
Closed

Implementation of new Replies functionality #5071

tinfoilboy opened this issue Dec 1, 2020 · 6 comments · Fixed by #4874

Comments

@tinfoilboy
Copy link

Is your feature request related to a problem? Please describe.
Discord has released the new replies feature for servers I believe about a week ago. I was looking to use that feature for my bot, however it does not seem like this library supports it yet, nor is there an issue/PR for it (I could actually most likely contribute the PR for this, just was making sure that it's not already in progress or the way that it should be done more than anything).

Describe the ideal solution
Adding a reply function for messages that leverages the new Reply flow, either off of the existing Message.reply method or making a new one like Message.threadReply.

Describe alternatives you've considered
There is the Message.reply function, however it looks messier compared to an actual threaded reply.

@almostSouji
Copy link
Member

almostSouji commented Dec 1, 2020

inline replies will be introduced in version 13 with #4874
that being said if you want to contribute a semver minor backport feel free!
"thread" however should be avoided, as threads are a different feature set which is not available at this time, but has been tested earlier (likely coming back).

@tinfoilboy
Copy link
Author

tinfoilboy commented Dec 1, 2020

Ah, I must have missed that PR 😆. Looks like in the issue the author of the original PR was looking to backport it themselves, however if that's not the case anymore definitely contribute towards that. Noted on the thread terminology as well. Would replyInline be a better function name in that case?

@kyranet kyranet linked a pull request Dec 6, 2020 that will close this issue
5 tasks
@kylerchin
Copy link
Contributor

idk why but that PR has been sitting there for the last 2 weeks with no one working on it. I'm sure many bot devs are itching for it now...

@tipakA
Copy link
Contributor

tipakA commented Dec 7, 2020

The PR that adds replies cannot be merged into v12, as it replaces current message.reply().
If you want to test it / need it so badly, no one stops you from installing the fork and using it.

@kylerchin
Copy link
Contributor

thanks @tipakA! Will it be merged into 13 or something? And is there like a timeline for it?

@tipakA
Copy link
Contributor

tipakA commented Dec 7, 2020

Yes, inline replies will arrive with v13, as Souji said in comment above (#5071 (comment)).

There is no timeline for v13 though.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants