perf(Presence): prefer boolean client status comparison before activi…

…ty checks (#10213) Prefer boolean client status comparison before activity checks Co-authored-by: Jacob Morrison <jake@matchmd.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
discordjs · Apr 20, 2024 · 4ad2858 · 4ad2858
1 parent 6759f5b
commit 4ad2858
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/discord.js/src/structures/Presence.js b/packages/discord.js/src/structures/Presence.js
@@ -123,11 +123,11 @@ class Presence extends Base {
       this === presence ||
       (presence &&
         this.status === presence.status &&
-        this.activities.length === presence.activities.length &&
-        this.activities.every((activity, index) => activity.equals(presence.activities[index])) &&
         this.clientStatus?.web === presence.clientStatus?.web &&
         this.clientStatus?.mobile === presence.clientStatus?.mobile &&
-        this.clientStatus?.desktop === presence.clientStatus?.desktop)
+        this.clientStatus?.desktop === presence.clientStatus?.desktop &&
+        this.activities.length === presence.activities.length &&
+        this.activities.every((activity, index) => activity.equals(presence.activities[index])))
     );
   }