Skip to content

Commit 40726db

Browse files
refactor: use formatters (#9956)
* refactor: use formatters * fix: imports * fix: imports pt.2 --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
1 parent 1e4ef35 commit 40726db

File tree

8 files changed

+28
-24
lines changed

8 files changed

+28
-24
lines changed

packages/discord.js/src/structures/BaseChannel.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22

3-
const { channelLink } = require('@discordjs/builders');
3+
const { channelLink, channelMention } = require('@discordjs/formatters');
44
const { DiscordSnowflake } = require('@sapphire/snowflake');
55
const { ChannelType, Routes } = require('discord-api-types/v10');
66
const Base = require('./Base');
@@ -89,7 +89,7 @@ class BaseChannel extends Base {
8989
* console.log(`Hello from ${channel}!`);
9090
*/
9191
toString() {
92-
return `<#${this.id}>`;
92+
return channelMention(this.id);
9393
}
9494

9595
/**

packages/discord.js/src/structures/DMChannel.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22

3-
const { userMention } = require('@discordjs/builders');
3+
const { userMention } = require('@discordjs/formatters');
44
const { ChannelType } = require('discord-api-types/v10');
55
const { BaseChannel } = require('./BaseChannel');
66
const TextBasedChannel = require('./interfaces/TextBasedChannel');

packages/discord.js/src/structures/Emoji.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
'use strict';
22

33
const process = require('node:process');
4+
const { formatEmoji } = require('@discordjs/formatters');
45
const { DiscordSnowflake } = require('@sapphire/snowflake');
56
const Base = require('./Base');
67

@@ -97,7 +98,7 @@ class Emoji extends Base {
9798
* reaction.message.channel.send(`The emoji used was: ${reaction.emoji}`);
9899
*/
99100
toString() {
100-
return this.id ? `<${this.animated ? 'a' : ''}:${this.name}:${this.id}>` : this.name;
101+
return this.id ? formatEmoji(this.id, this.animated) : this.name;
101102
}
102103

103104
toJSON() {

packages/discord.js/src/structures/Message.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

3-
const { messageLink } = require('@discordjs/builders');
43
const { Collection } = require('@discordjs/collection');
4+
const { messageLink } = require('@discordjs/formatters');
55
const { DiscordSnowflake } = require('@sapphire/snowflake');
66
const {
77
InteractionType,

packages/discord.js/src/structures/Role.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
'use strict';
22

3+
const { roleMention } = require('@discordjs/formatters');
34
const { DiscordSnowflake } = require('@sapphire/snowflake');
45
const { PermissionFlagsBits } = require('discord-api-types/v10');
56
const Base = require('./Base');
@@ -452,7 +453,7 @@ class Role extends Base {
452453
*/
453454
toString() {
454455
if (this.id === this.guild.id) return '@everyone';
455-
return `<@&${this.id}>`;
456+
return roleMention(this.id);
456457
}
457458

458459
toJSON() {

packages/discord.js/src/structures/User.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22

3-
const { userMention } = require('@discordjs/builders');
3+
const { userMention } = require('@discordjs/formatters');
44
const { calculateUserDefaultAvatarIndex } = require('@discordjs/rest');
55
const { DiscordSnowflake } = require('@sapphire/snowflake');
66
const Base = require('./Base');

packages/discord.js/src/util/Formatters.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ const {
1919
TimestampStyles,
2020
underscore,
2121
userMention,
22-
} = require('@discordjs/builders');
22+
} = require('@discordjs/formatters');
2323

2424
/**
2525
* Formats an application command name and id into an application command mention.

packages/discord.js/typings/index.d.ts

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,41 @@
11
import {
22
ActionRowBuilder as BuilderActionRow,
33
MessageActionRowComponentBuilder,
4+
ButtonBuilder as BuilderButtonComponent,
5+
EmbedBuilder as BuildersEmbed,
6+
ChannelSelectMenuBuilder as BuilderChannelSelectMenuComponent,
7+
MentionableSelectMenuBuilder as BuilderMentionableSelectMenuComponent,
8+
RoleSelectMenuBuilder as BuilderRoleSelectMenuComponent,
9+
StringSelectMenuBuilder as BuilderStringSelectMenuComponent,
10+
UserSelectMenuBuilder as BuilderUserSelectMenuComponent,
11+
TextInputBuilder as BuilderTextInputComponent,
12+
SelectMenuOptionBuilder as BuildersSelectMenuOption,
13+
ModalActionRowComponentBuilder,
14+
ModalBuilder as BuildersModal,
15+
AnyComponentBuilder,
16+
ComponentBuilder,
17+
type RestOrArray,
18+
ApplicationCommandOptionAllowedChannelTypes,
19+
} from '@discordjs/builders';
20+
import {
421
blockQuote,
522
bold,
6-
ButtonBuilder as BuilderButtonComponent,
723
channelMention,
824
codeBlock,
9-
EmbedBuilder as BuildersEmbed,
1025
formatEmoji,
1126
hideLinkEmbed,
1227
hyperlink,
1328
inlineCode,
1429
italic,
1530
quote,
1631
roleMention,
17-
ChannelSelectMenuBuilder as BuilderChannelSelectMenuComponent,
18-
MentionableSelectMenuBuilder as BuilderMentionableSelectMenuComponent,
19-
RoleSelectMenuBuilder as BuilderRoleSelectMenuComponent,
20-
StringSelectMenuBuilder as BuilderStringSelectMenuComponent,
21-
UserSelectMenuBuilder as BuilderUserSelectMenuComponent,
22-
TextInputBuilder as BuilderTextInputComponent,
23-
SelectMenuOptionBuilder as BuildersSelectMenuOption,
2432
spoiler,
2533
strikethrough,
2634
time,
2735
TimestampStyles,
2836
underscore,
2937
userMention,
30-
ModalActionRowComponentBuilder,
31-
ModalBuilder as BuildersModal,
32-
AnyComponentBuilder,
33-
ComponentBuilder,
34-
type RestOrArray,
35-
ApplicationCommandOptionAllowedChannelTypes,
36-
} from '@discordjs/builders';
38+
} from '@discordjs/formatters';
3739
import { Awaitable, JSONEncodable } from '@discordjs/util';
3840
import { Collection, ReadonlyCollection } from '@discordjs/collection';
3941
import { BaseImageURLOptions, ImageURLOptions, RawFile, REST, RESTOptions } from '@discordjs/rest';

0 commit comments

Comments
 (0)