Skip to content

Commit 2e5ee2f

Browse files
committed
detach fiber from dom
1 parent d28ee48 commit 2e5ee2f

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

packages/react-dom/src/client/ReactDOMComponentTree.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@
88
import {HostComponent, HostText} from 'shared/ReactWorkTags';
99
import invariant from 'shared/invariant';
1010

11-
const randomKey = Math.random()
12-
.toString(36)
13-
.slice(2);
14-
const internalInstanceKey = '__reactInternalInstance$' + randomKey;
15-
const internalEventHandlersKey = '__reactEventHandlers$' + randomKey;
11+
// const randomKey = Math.random()
12+
// .toString(36)
13+
// .slice(2);
14+
const internalInstanceKey = '__reactInternalInstance$';
15+
const internalEventHandlersKey = '__reactEventHandlers$';
1616

1717
export function precacheFiberNode(hostInst, node) {
1818
node[internalInstanceKey] = hostInst;

packages/react-reconciler/src/ReactFiberCommitWork.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -728,6 +728,9 @@ function commitUnmount(current: Fiber): void {
728728
}
729729
case HostComponent: {
730730
safelyDetachRef(current);
731+
// HACK: detach fiber references from DOM
732+
current.stateNode.__reactEventHandlers$ = null;
733+
current.stateNode.__reactInternalInstance$ = null;
731734
break;
732735
}
733736
case HostPortal: {

0 commit comments

Comments
 (0)