🚧 Initial Discord message components v2 implementation

[Log1x]

🚧 Work in progress.

Completely blind & untested. Should be able to try it later today.

Edit: everything appears to be functional.

[Lulalaby]

P neat implementation ❤️ Good job!

[valzargaming]

The v2 contract was an excellent idea, and something I'd like to see in other parts of the library. It would certainly cut down on a lost of instances of checking against hardcoded types like this.

[SQKo]

the property might be not set yet

Suggested change

	* @return int
	*/
	public function getFlags(): int
	{
	return $this->flags;
	* @return ?int
	*/
	public function getFlags(): ?int
	{
	return $this->flags;

[SQKo]

The official name is IS_COMPONENTS_V2

Suggested change

	public const FLAG_V2_COMPONENTS = (1 << 15);
	public const FLAG_IS_V2_COMPONENTS = (1 << 15);

please also adjust the referencing code

[SQKo]

Please import directly, so it is easy to update/refactor in future (or alias as seen in functions.php)

use Discord\Builders\Components\ActionRow;

use Discord\Builders\Components\SelectMenu;

Suggested change

	} elseif (! ($component instanceof Components\ActionRow || $component instanceof Components\SelectMenu)) {
	} elseif (! ($component instanceof ActionRow || $component instanceof SelectMenu)) {

[SQKo]

Please also adjust the class implements Components\xx to have the namespace imported per my previous suggestion

[SQKo]

Suggested change

	'loading_state' => $this->loading_state ?? null,
	'loading_state' => $this->loading_state,

loading_state will be always set since isResolved() returns true

[SQKo]

Implement validation of $url like in Embed::ensureValidUrl()

[SQKo]

The spec actually expects the media to contain UnfurledMediaItem, even though only the url for now that will be taken, that is what you can deal with inside jsonSerialize()

Needs to change on the getter too

For example

Suggested change

	* @param string $url URL of the media item.
	*
	* @return $this
	*/
	public function setMedia(string $url): self
	{
	$this->media = ['url' => $url];
	* @param UnfurledMediaItem|string $url URL of the media item.
	*
	* @return $this
	*/
	public function setMedia(UnfurledMediaItem|string $url): self
	{
	if (is_string($url)) {
	$url = UnfurledMediaItem::new($url);
	}
	$this->media = $url;

with this we can anticipate more changes in future

[SQKo]

Suggested change

	/**
	* Set the spacing size to small.
	*
	* @return $this
	*/
	public function setSpacingSmall(): self
	{
	return $this->setSpacing(self::SPACING_SMALL);
	}
	/**
	* Set the spacing size to large.
	*
	* @return $this
	*/
	public function setSpacingLarge(): self
	{
	return $this->setSpacing(self::SPACING_LARGE);
	}

Don't think this is necessary when there is a setSpacing() already, we don't want the code to get huge when there is another type of spacing in future

[SQKo]

Suggested change

	throw new \InvalidArgumentException('Section can only contain TextDisplay components. Use setAccessory() for Thumbnail or Button.');
	throw new \InvalidArgumentException('Section can only contain TextDisplay components.');

You are not checking wether the $component is a Thumbnail or Button here so it's better not to explicitly say that.

[SQKo]

On a second though, the spec is telling us to not hardcode this, so we should not validate this yet

Suggested change

	throw new \InvalidArgumentException('Section can only contain TextDisplay components. Use setAccessory() for Thumbnail or Button.');
	trigger_error('Section may only contain TextDisplay components.', E_USER_NOTICE);

[SQKo]

The spec is telling us to not hard code the supported components yet (anyway leave the phpdoc as is)

Suggested change

	public function setAccessory(Thumbnail|Button $component): self
	{
	$this->accessory = $component;
	public function setAccessory(Component $component): self
	{
	if (! ($component instanceof Thumbnail || $component instanceof Button)) {
	trigger_error('Accessory may only contain Thumbnail or Button component.', E_USER_NOTICE);
	}
	$this->accessory = $component;

[SQKo]

Suggested change

	if ($description !== null && strlen($description) > 1024) {
	if ($description !== null && poly_strlen($description) > 1024) {

multibyte

[SQKo]

might want to validate the component type that can be added here or perhaps strict type them

[SQKo]

According to the spec, using the components v2 may disable content and embeds, it would be good to warn the users in the MessageBuilder to avoid confusion

Also seems this PR has not supported webhooks yet