Merge pull request esnet#283 from camflan/fix-resizable-unsubscribe

sartaj10 · web-flow · commit 3a7fcccb36c5 · 2018-07-06T14:08:00.000-07:00
Resizable Memory leak
diff --git a/src/components/Resizable.js b/src/components/Resizable.js
@@ -23,12 +23,12 @@ export default class Resizable extends React.Component {
     }
 
     componentDidMount() {
-        window.addEventListener("resize", () => this.handleResize());
+        window.addEventListener("resize", this.handleResize);
         this.handleResize();
     }
 
     componentWillUnmount() {
-        window.removeEventListener("resize", () => this.handleResize());
+        window.removeEventListener("resize", this.handleResize);
     }
 
     handleResize() {

Original file line number	Diff line number	Diff line change
`@@ -23,12 +23,12 @@ export default class Resizable extends React.Component {`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`componentDidMount() {`
`26`		`- window.addEventListener("resize", () => this.handleResize());`
	`26`	`+ window.addEventListener("resize", this.handleResize);`
`27`	`27`	`this.handleResize();`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`componentWillUnmount() {`
`31`		`- window.removeEventListener("resize", () => this.handleResize());`
	`31`	`+ window.removeEventListener("resize", this.handleResize);`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`handleResize() {`