Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lookup loading #6

Open
thatbudakguy opened this issue Jul 30, 2022 · 0 comments
Open

Fix lookup loading #6

thatbudakguy opened this issue Jul 30, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@thatbudakguy
Copy link
Member

The way lookups are loaded now doesn't seem to be right. The files themselves are available in tests:

py_lookup_path = spacy.registry.lookups.get("och")()["pinyin"]
pinyin = srsly.read_json(py_lookup_path)
self.assertEqual(pinyin["㐁"], ["tiàn"])

But what we really want is for the table to be preloaded and available at nlp.vocab.lookups. Maybe this will require setting up an entry point for the lookups.

@thatbudakguy thatbudakguy added the bug Something isn't working label Jul 30, 2022
@thatbudakguy thatbudakguy self-assigned this Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant