Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating migration depends on docker #19

Closed
BinodKafle opened this issue May 28, 2021 · 2 comments · Fixed by #22
Closed

Creating migration depends on docker #19

BinodKafle opened this issue May 28, 2021 · 2 comments · Fixed by #22
Labels
enhancement New feature or request

Comments

@BinodKafle
Copy link
Collaborator

When I tried to create migration without starting the server on docker, it throws the following error
image
I think creating migration should not depend on whether the server is started or not and more importantly it's started on docker or not.

@BinodKafle BinodKafle added the enhancement New feature or request label May 28, 2021
@dipeshdulal
Copy link
Owner

dipeshdulal commented Jun 21, 2021

Yes, I think we need to decouple the migration logic whether to use docker or base system for migration runner.
Commands like;

  • make docker migrate

Or using flags in make command.
I don't know much about the make command but @dipeshhkc can shed some light into this as well.

@dipeshdulal
Copy link
Owner

Looks like; this Stack Overflow answer has the solution to send custom variables to make file.

make foo=bar target

We could use this syntax to migrate without docker. eg; make provider=host migrate for host migration runner and make provider=docker migrate for docker based migration runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants