Skipping Transformer

[rolfnl]

Perhaps a config setting to disable the use of Fractal or at least a check inside the morph method (Response) or check inside transformableResponse method for example to see if getTransformers returns empty (to skip the rest of the transform actions.

I'm playing with Fractal for example but not transforming Eloquent models because the data being used can come from different sources, so I sort of normalise the result. Then I can't use the Dingo API::transform setters properly. I tried to hack some more generic setter but didn't like it so far (so for I sent already transformed results as response).

You know what I mean? (sorry bit in a hurry but can elaborate)

[jasonlewis]

Not sure what you mean. If you don't want to use transformers then simply
don't bind a transformer to the model.
On 2 May 2014 03:15, "Rolf" notifications@github.com wrote:

Perhaps a config setting to disable the use of Fractal or at least a check
inside the morph method (Response) or check inside transformableResponse
method for example to see if getTransformers returns empty (to skip the
rest of the transform actions.

I'm playing with Fractal for example but not transforming Eloquent models
because the data being used can come from different sources, so I sort of
normalise the result. Then I can't use the Dingo API::transform setters
properly. I tried to hack some more generic setter but didn't like it so
far (so for I sent already transformed results as response).

You know what I mean? (sorry bit in a hurry but can elaborate)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/24
.

[rolfnl]

Yes you're right, I had some dirty code in my tests and was sending arrays to the response which were caught by the hasTransformer method which in return gave an error. I was about to post a check for that in the function, but I see you just committed a fix yourself; bb12cdf

It's all good..

Though I think it's cheaper to check for the existence of transformers first before testing if the response has any;
https://github.com/dingo/api/blob/master/src/Http/Response.php#L48
If there are no bound transformers than there's no need to further check, right? But hey, this is nitpicking... feel free to close this

[jasonlewis]

But that is checking for the existence of a transformer? Do you mean check if the response is an array there and not do that transformableResponse?

[rolfnl]

Before if (static::$transformer->transformableResponse($response)) you could check if there are any transformers at all e.g. if ( ! empty(static::$transformer->getTransformers())) before verifying if the response is transformable.

It doesn't break now, it's just an addition.

[jasonlewis]

Ah, probably wouldn't make a heck of a lot of difference in the grand scheme of things.