Cleanups #21
Merged
Cleanups #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndSubgraphRecursive
This was my mistake when we discussed this before, I thought AsString was a thing in GAP but it turns out it isn't.
This reverts commit 7f49516.
Also add \= for edges
Member
Author
|
@mpan322 This PR contains a bunch of refactoring, none of it is profoundly different from what you wrote, it's just fussing around the edges. Are you happy with the changes in this PR? |
This was referenced May 15, 2024
Member
Author
|
@mpan322 can you please review this PR? If you're happy with the changes as they are, then that's great, if not, please let me know! |
mpan322
approved these changes
May 18, 2024
Contributor
|
Sorry for the slow review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a bunch of renaming, deduplication of functions, and rearranging of stuff. It doesn't change anything really fundamental, just around the edges (in a non-graphviz sense).