Add tagging support to Karakeep export #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhanced KarakeepClient with get_all_tags() and add_tags_to_bookmark() methods - Added tag caching and automatic ID generation for new tags - Updated export logic to parse existing tags column and attach to Karakeep bookmarks - Added graceful handling for databases with/without tags column - Maintains backward compatibility with existing functionality - All tests passing 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fixed tag parsing to properly handle Pocket's nested JSON format: {"tag_name": {"tag": "tag_name", "item_id": "123"}}
- Extract tag names from the nested 'tag' field within each tag object
- Maintain fallback to key names if nested structure not found
- Updated comments with appropriate examples
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Add logging to show tags_data from database for each item - Add logging to show parsed tag names and count - Add specific logging for items with no tags vs no bookmark_id - Help troubleshoot tag processing during export 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive tagging support to the Karakeep export functionality, allowing tags from Pocket bookmarks to be automatically transferred to Karakeep during export.
Key Features
Implementation Details
KarakeepClientwithget_all_tags()andadd_tags_to_bookmark()methodsAPI Integration
/api/v1/tagsendpoint/api/v1/bookmarks/:bookmarkId/tagsendpointTesting
🤖 Generated with Claude Code