Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make period a required field for uptime alert #828

Merged

Conversation

mikesmithgh
Copy link
Contributor

Hi, I am working digitalocean/doctl#1419 as part of #hacktoberfest and discovered period is not defined as a required field in the spec.

If I attempt to post a request without period then I receive

{
    "id": "Internal Server Error",
    "message": "Server Error"
}

The field is also required on the UI.
uptime-alert-screenshot

@danaelhe
Copy link
Member

danaelhe commented Oct 9, 2023

GREAT catch! Will merge on green 🚀 thank you!

Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants