driver: validate capabilities for volume creation #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
We don't validate the capabilities during `CreateVolume()`. We should start doing it to avoid creating volumes that needs to be in different modes, such as `MULTI_NODE_MULTI_WRITER` (ReadWriteMany in k8s) or `MULTI_NODE_READER_ONLY` (ReadOnlyMany in k8s) Note that, there is a [bug](kubernetes-csi/external-provisioner#117) in the `external-provisioner` sidecar that passes down the Kubernetes `accessModes` fields to the CSI plugin. It currently passes a hardcoded value of `SINGLE_NODE_WRITER` (see: https://github.com/kubernetes-csi/external-provisioner/blob/4d8a86cc54901d4d14b56c03a6ee7dfe6482c9b1/pkg/controller/controller.go#L89), so this means currently it's not possible to create volumws with `ReadWriteMany` or `ReadOnlyMany` nevertheless. But it's good we have the check in place, so we'de protected once the issue in the provisioner is fixed in the future. closes #42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't validate the capabilities during
CreateVolume(). We shouldstart doing it to avoid creating volumes that need to be in different
modes, such as
MULTI_NODE_MULTI_WRITER(ReadWriteMany in k8s) orMULTI_NODE_READER_ONLY(ReadOnlyMany in k8s)Note that, there is a bug in the
external-provisionersidecar that passes down the KubernetesaccessModesfields to the CSI plugin. It currently passes a hardcoded value ofSINGLE_NODE_WRITER(see: https://github.com/kubernetes-csi/externalprovisioner/blob/4d8a86cc54901d4d14b56c03a6ee7dfe6482c9b1/pkg/controller/controller.go#L89), so this means currently it's not possible to create volumes withReadWriteManyorReadOnlyManynevertheless.But it's good we have the check in place, so we're protected once the
issue in the provisioner is fixed in the future.
closes #42