Change secret name to digitalocean

[fatih]

This means that users that already have created a token for
cloud-controller-manager can use the same token for the CSI plugin

• checkout namespace compatibility

Fixes #20

[fatih]

@andrewsykim can you please comment on the namespace compatibility. I see that CCM is using kube-system, but we don't do it for CSI. I believe therefore, even if I change the name, it's not going to work out because the CCM secret lives in a separate namespace. The CSI secret lives in the default namespace. Happy to change it for our own case, just wonder the reason why CCM uses kube-system.

[aybabtme]

registrar

[andrewsykim]

CCM uses kube-system since it is technically a component of the kubernetes control plane. Like you said I think the best option going forward (at least for now) is just to duplicate the secret for this use case.

[fatih]

I see. I'm not sure why the CSI plugin should live in kube-system. That namespace is meant for services that are created by Kubernetes:

The namespace for objects created by the Kubernetes system

Do you think it's better we change the default namespace for CCM to default?

[fatih]

Andrew shared this with me and seems like CCM is deployed into kube-system and is totally ok. It's also a part of Kubernetes. https://kubernetes.io/docs/tasks/administer-cluster/running-cloud-controller/#examples

There are two solutions I can think now:

1. Duplicate secrets. This is the easiest way
2. Move CSI to kube-system and make it coherent with CCM

Let me look into the second option and how others do the Kubernetes deployment story of a CSI plugin.

[aybabtme]

Seems to me that if CCM is a kube-system then the case is even stronger for CSI to be a kube-system?

[fatih]

@aybabtme true that. Moving it to kube-system. Will update the PR now

[fatih]

@aybabtme @andrewsykim moved to kube-system and fixed review comments. PTAL.

[lxfontes]

should this be kube-system ?

[lxfontes]

kube-system

[lxfontes]

kube-system

[fatih]

@lxfontes thanks for catching these. Fixed it.

[lxfontes]

lgtm

[cagedmantis]

lgtm