Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use fetchAndPersistBracket instead of fetchAndPersist #11158

Closed
S11001001 opened this issue Oct 6, 2021 · 0 comments · Fixed by #12672
Closed

use fetchAndPersistBracket instead of fetchAndPersist #11158

S11001001 opened this issue Oct 6, 2021 · 0 comments · Fixed by #12672
Labels
component/json-api HTTP JSON API good first issue Good for newcomers team/ledger-clients Related to the Ledger Clients team's components.

Comments

@S11001001
Copy link
Contributor

#10617 mentions that fetchAndPersistBracket can be used for the non-websocket use cases where plain fetchAndPersist is currently used. It's probably a broadly good idea. The task here is to port every caller of the latter to the former, following the current example as well as the advice of #11157, and then make fetchAndPersist a private[this] function.
@S11001001 S11001001 added good first issue Good for newcomers component/json-api HTTP JSON API team/ledger-clients Related to the Ledger Clients team's components. labels Oct 6, 2021
@skisel skisel mentioned this issue Jan 31, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/json-api HTTP JSON API good first issue Good for newcomers team/ledger-clients Related to the Ledger Clients team's components.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use fetchAndPersistBracket instead of fetchAndPersist skisel/daml
1 participant
@S11001001