Skip to content

add: auto release with sha #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

add: auto release with sha #39

merged 1 commit into from
Jun 24, 2025

Conversation

Tieqiong
Copy link
Contributor

@sbillinge please check, thanks

This will automatically GitHub release after a tag being pushed by maintainer or admin with the tag message + correct sha256 in the release message

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice. We are using centralized workflows now, in scikit-package/release scripts. To reduce maintenance in the future, please could you look into incorportating this as much as possible into a more centralized worklow that we just call from here? You can loop in Bob with questions.

@Tieqiong
Copy link
Contributor Author

@sbillinge Thanks for the suggestion. The point of a centralized workflow is to offer a reusable, consistent process—but our C++ library’s build and release steps are quite different from our Python packages, and we don’t yet have a skpkg standard for C++ modules. Folding this into the central repo today would either clutter it with C++-specific logic or introduce extra layers here, without real benefit.
Since we expect this library to be heavily modified and updated, with any possible future skpkg C++ standard to evolve rapidly, a temporary dedicated workflow in this repo is simpler and more maintainable for now. Once we’ve defined a skpkg C++ standard, we can migrate it back upstream.

@sbillinge
Copy link
Contributor

sounds good. I agree.

@sbillinge sbillinge merged commit ec370af into diffpy:windows Jun 24, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants