-
Notifications
You must be signed in to change notification settings - Fork 21
More info on updating global config for users #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
==========================================
+ Coverage 96.49% 96.54% +0.05%
==========================================
Files 8 8
Lines 342 347 +5
==========================================
+ Hits 330 335 +5
Misses 12 12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see inline. news needs fixing but otherwise this is great
news/config-UX.rst
Outdated
@@ -0,0 +1,23 @@ | |||
**Added:** | |||
|
|||
* additional information to users to relieve frustration in finding how to update global config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no functionality added. Move this to Fixed
@sbillinge fixed news item, ready for review |
btw @alisnwu I closed this before reading https://www.diffpy.org/diffpy.utils/examples/toolsexample.html but there I saw no clear information about how to update the default user information. I would put it as an enumerated list to make it clearer. there are at least 4 different ways of setting these things with more or less permanence. Make it as an enumerated list. But also discuss with and example how to updage your default file using a text editor. Also, is this a typo?
|
moved this comment to issue #210 |
closes #156
@sbillinge ready for review, new message points to where users can update manually and examples on the diffpy.utils link