Fix atom-structure pickle #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix deprecation warning in Python 3.7 on `Iterable` move to `collections.abc`.
Import it as `copymod` so it does not shadow argument name.
This fails in Python 3.7.
Make sure first Atom stays contained after un-pickling. Use more delicate copying behavior in `Structure.extend()`.
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
+ Coverage 94.65% 94.69% +0.04%
==========================================
Files 43 43
Lines 4973 4998 +25
==========================================
+ Hits 4707 4733 +26
+ Misses 266 265 -1
Continue to review full report at Codecov.
|
Also use more descriptive variable names. No change in code function.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI - only, do not merge.
Fix Atom/Structure identity relation after pickling which broke in Python 3.7:
Fixes diffpy/diffpy.srfit#56.