Skip to content

skpkg: final skpkg migration of files #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 26, 2025

Conversation

cadenmyers13
Copy link
Contributor

After this, everything in srreal should be up to date! We can check it off the list.

@cadenmyers13
Copy link
Contributor Author

@sbillinge it says workflow needs approval...?

@sbillinge
Copy link
Contributor

@cadenmyers13 its failing tests. It looks like it needs the environment.yml file, but try and see. When you ran skpkg, did you select that it has c-code? if not, then we need to redo it. If yes, then we need to loop in @Tieqiong and @bobleesj to understand what is different here.

@sbillinge
Copy link
Contributor

actually, since you are mergint into cookie, it is possible that we need to merge main into cookie to get tests to pass. see if you can figure out how to get tests running locally, first on main and then on cookie.

@cadenmyers13
Copy link
Contributor Author

When you ran skpkg, did you select that it has c-code?

@sbillinge yes i did do that. I'll try to get test passing locally

@cadenmyers13
Copy link
Contributor Author

@sbillinge I configured the tests-on-pr.yml to run without the environment.yml file. I tested it on a PR on my fork and all the tests passed: cadenmyers13#1. This is my first time configuring the CI so please check that everything looks okay here. I put in some effort to understand whats actually happening so I'm fairly confident this isn't just "magic".

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one quick comment left.


.. _getting-started:

================
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may want to leave this here as a stub or remove it. If we leave it, the wording could change to something like "getting started information will appear here shortly" and make an issue to do it.

On the whole, it may be better to just delete it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbillinge yeah we can remove it. If we want to use the format later we can just pull it from skpkg.

@cadenmyers13
Copy link
Contributor Author

@sbillinge Okay, i removed that file. should be good!

@sbillinge sbillinge merged commit 724018c into diffpy:cookie Jun 26, 2025
13 checks passed
@cadenmyers13 cadenmyers13 deleted the skpkg-migration branch June 26, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants