-
Notifications
You must be signed in to change notification settings - Fork 21
skpkg: final skpkg migration of files #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sbillinge it says workflow needs approval...? |
@cadenmyers13 its failing tests. It looks like it needs the environment.yml file, but try and see. When you ran skpkg, did you select that it has c-code? if not, then we need to redo it. If yes, then we need to loop in @Tieqiong and @bobleesj to understand what is different here. |
actually, since you are mergint into cookie, it is possible that we need to merge main into cookie to get tests to pass. see if you can figure out how to get tests running locally, first on main and then on cookie. |
@sbillinge yes i did do that. I'll try to get test passing locally |
@sbillinge I configured the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one quick comment left.
doc/source/getting-started.rst
Outdated
|
||
.. _getting-started: | ||
|
||
================ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we may want to leave this here as a stub or remove it. If we leave it, the wording could change to something like "getting started information will appear here shortly" and make an issue to do it.
On the whole, it may be better to just delete it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbillinge yeah we can remove it. If we want to use the format later we can just pull it from skpkg.
@sbillinge Okay, i removed that file. should be good! |
After this, everything in srreal should be up to date! We can check it off the list.