skpkg: pre-commit auto fixes with line length of 79 #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadenmyers13
commented
Jun 23, 2025
| @@ -52,7 +53,8 @@ def get_objcryst_libraries(): | |||
| conda_prefix = os.environ.get("CONDA_PREFIX") | |||
| if not conda_prefix: | |||
| raise EnvironmentError( | |||
| "CONDA_PREFIX is not set. Please install ObjCryst using conda and activate the environment." | |||
| "CONDA_PREFIX is not set. " | |||
| "Please install ObjCryst using conda and activate the environment." | |||
There was a problem hiding this comment.
Manual line length fix (1 of 2 fixes)
cadenmyers13
commented
Jun 23, 2025
| @@ -64,7 +66,8 @@ def get_objcryst_libraries(): | |||
| stem = Path(fn).stem | |||
| if "objcryst" not in stem.lower(): | |||
| continue | |||
| # strip a leading "lib" so that setuptools does -lObjCryst, not -llibObjCryst | |||
| # strip a leading "lib" | |||
| # so that setuptools does -lObjCryst, not -llibObjCryst | |||
There was a problem hiding this comment.
manual line length fix (2 of 2 fixes)
|
I also incorporated docformatting autofixes here since they werent in the pyproject.toml |
|
@sbillinge ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last autofix PR had a black linelength requirement of 115. This PR changes this to 79 (skpkg standard) and makes those auto fixes.
There are only two flake8 errors that need to be addressed regarding line length. Because these are simple and quick, I will also put them on this PR and make note inline of where exactly I made these manual fixes.