fix: find objcryst #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tieqiong it looks good. I have really no way of checking if this is good or not. I think the check is whether it works.; How do we check that? Should it build locally on all platforms? Or what is the way to test this. Also, we should decide if we stay at 115 length lines or make the mods to 79. On the whole, I am inclined to the latter to remove hassle later.....but we could do it either way. That work can be done by one of the other people. |
|
this is passing tests. @Tieqiong do you want me to merge this? |
|
@sbillinge I'm setting up a poor man matrix test now. We can merge it after that as this one is a bit tricky. Also yes let's keep our 79 length |
|
@sbillinge Beautiful. Let's merge this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sbillinge please check, thanks!